[TIMOB-15405] 3.2.0 CLI doesn't add all symbols when compiling ad-hoc
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2013-10-08T20:38:20.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | 2013 Sprint 21, 2013 Sprint 21 Core, Release 3.2.0 |
| Components | CLI |
| Labels | cli, ios, qe-closed-3.2.0, qe-testadded |
| Reporter | Dan Tamas |
| Assignee | Chris Barber |
| Created | 2013-10-07T16:36:34.000+0000 |
| Updated | 2014-02-12T08:02:28.000+0000 |
Description
There is a an error in the *iphone/cli/commands/_build.js* file that prevent all the symbols to set to *define.h* in production.
The function *addSymbol* resets the symbols matrix to an empty array each time it is called.
this.symbols[id] = [];
if (!Array.isArray(this.symbols[id])) {
this.symbols[id] = [];
}
Attachments
| File | Date | Size |
|---|---|---|
| app.js | 2013-10-18T23:15:09.000+0000 | 2760 |
Master pull request: https://github.com/appcelerator/titanium_mobile/pull/4771
To test, build the attached app.js for iOS device, then check that the build/iphone/classes/defines.h contains USE_TI_MEDIA.
Tested with Appcelerator Studio, build: 3.2.0.201310180526 SDK, build 3.2.0.v20131018135643 CLI 3.2.0 Mac osx 10.9 Mavericks Built for iOS device 5c iOS version 7.0.2, checked that the build/iphone/classes/defines.h contains USE_TI_MEDIA.