[TIMOB-15635] Android: anyDensity is set to false always

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2013-11-05T17:38:43.000+0000
Affected Version/s	Release 3.2.0
Fix Version/s	2013 Sprint 23, 2013 Sprint 23 Core, Release 3.2.0
Components	Android
Labels	SupportTeam, androidbuild, cb-verified, qe-closed-3.2.0
Reporter	Dan Tamas
Assignee	Chris Barber
Created	2013-11-01T09:23:50.000+0000
Updated	2014-06-19T12:44:11.000+0000

Description

The build process sets anyDensity to false without taking in account the tiapp.xml setting.

Comments

Motiur Rahman 2013-11-01

Hi Dan Tamas, Actually i don't find anyDensity is set to false always in tiapp.xml file please notify me clearly with some resource. Thanks
Dan Tamas 2013-11-01

Are you kidding? What is not clear?
Chris Barber 2013-11-04

[~rborn] Hey Dan, I just tested this and even I'm not sure exactly what the problem is. I don't think the build process has ever set anyDensity to false. If I put the following in my tiapp.xml, anyDensity remains true in the final AndroidManifest.xml: <?xml version="1.0" encoding="UTF-8"?> <ti:app xmlns:ti="http://ti.appcelerator.org">  <android xmlns:android="http://schemas.android.com/apk/res/android"> <manifest> <supports-screens android:anyDensity="true" android:largeScreens="true" android:normalScreens="true" android:smallScreens="true"/> </manifest> </android> </ti:app> So, either: 1) You are using a custom AndroidManifest.xml and I have a bug (possible) 2) There was a bug that was fixed in one of the 12+ CI builds since 3.2.0.v20131030184044 (likely) 3) You forgot to put "android:" before the "anyDensity" (unlikely, but possible) 4) You put the tag someplace that was NOT in the tag. The new Android build system is VERY strict about the tags. If you put anywhere besides in the tag, it disappears... forever! To match parity with iOS and how it handles precedence, the custom AndroidManifest.xml wins over the default AndroidManifest.xml and the in the tiapp.xml wins over the custom AndroidManifest.xml and default AndroidManifest.xml.

Dan Tamas 2013-11-04

Hi Chris, here is the android part tiapp.xml. The support-screens is a little different, and I tried with 3.2.0.v20131031141643 No custom manifest file :) However I right now I'm not able to test, so this is something for you just to know. As soon as I'll be able I'll run some tests with the latest CI and let you know. Thank you.

       <android xmlns:android="http://schemas.android.com/apk/res/android">
           <application android:debuggable="true"/>
           <tool-api-level>10</tool-api-level>
           <manifest android:installLocation="preferExternal">
               <uses-sdk android:minSdkVersion="10" android:targetSdkVersion="10"/>
   
               <supports-screens android:anyDensity="true"/>
   
               <uses-permission android:name="android.permission.READ_CALENDAR"/>
               <uses-permission android:name="android.permission.WRITE_CALENDAR"/>
               <uses-permission android:name="android.permission.RECORD_AUDIO"/>
               <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
               <uses-permission android:name="android.permission.VIBRATE"/>
   	    <uses-permission android:name="android.permission.READ_PHONE_STATE"/>
           </manifest>
           <activities>
               <activity url="app.js">
                   <intent-filter>
                       <action android:name="android.intent.action.VIEW"/>
                       <category android:name="android.intent.category.DEFAULT"/>
                       <category android:name="android.intent.category.BROWSABLE"/>
                   </intent-filter>
               </activity>
               <activity url="loading_android.js" android:theme="@android:style/Theme.Translucent.NoTitleBar" android:launchMode="singleTask"></activity>
           </activities>
           <services>
               <service android:process=":gcmnotification" url="gcm.js"/>
           </services>
       </android>

Chris Barber 2013-11-04

[~rborn] Cool. Looks pretty cut and dry. Let me know how the most recent CI build does. FYI, is deprecated in favor of , so now you can shave some bytes off your tiapp.xml. Just out of curiosity, when you look at build/android/AndroidManifest.xml, is anyDensity set to false? Or is it when your app is running? Or are you determining this based on behavior? Are you doing an emulator build or device build? If device, does the name of it start with X, end with M, and have a OO in the middle? For fun, I grepped the Android source and found that there is a variable ingeniously named "anyDensityFalse" which is initialized to false and set to whatever true if the device supports it (based on the ApplicationInfo object). Personally, I think it would have been better to name it "anyDensityNotTrue" and have it initialized to !true. False is just so negative.
Dan Tamas 2013-11-04

@Chris - I tested with 3.2.0.v20131104014843 and it seems that the anyDensity is back. I didn't make any change to tiapp.xml so it seems to be fixed. However I didn't make more tests with more apps, just had 5 mins to run a fast compile :) I'll try later this days (this week) to run more tests and see how it's working. Thank you.
Dan Tamas 2013-11-04

I lied :( I cleaned the project, recompiled and here it is (in the generated manifest file) <supports-screens android:anyDensity="false"/> More info: - I detected this behaviour because the screens don't fit anymore, they are huge - the project is old and at that moment that was the way to keep all the screen sizes happy - deploy to emulator with android 2.3.4 - as mentioned before, the anyDensity is set to false in the generated AndroidManifest.xml What else do you need to know? Thank you :)
Chris Barber 2013-11-04

Dan: 1, Chris: 0. Pull request: https://github.com/appcelerator/titanium_mobile/pull/4909 To test, un-Earth a module with a timodule.xml that contains: <android> <manifest> <supports-screens android:anyDensity="false"/> </manifest> </android> Build an Android app and verify the generated build/android/AndroidManifest.xml.
Dan Tamas 2013-11-04

Haha, nice catch. Indeed I have a module with anyDensity set to false. Thanks a lot, waiting for the merge and I'll let you know
Samuel Dowse 2013-12-05

Verified fixed on: Mac OSX 10.9 Mavericks Titanium Studio, build: 3.2.0.201312031529 Titanium SDK, build: 3.2.0.v20131203104847 CLI: 3.2.0-beta Alloy: 1.3.0-beta Tested using Chris Barber's test steps. Included code in the tiapp.xml and added modules with with anyDensity set to false. AndroidManifest.xml still had anyDensity set to true after build. Closing.

JSON Source