Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-1597] [PATCH] TiDomElement.setAttribute not implemented on iPhone

GitHub Issuen/a
TypeBug
PriorityTrivial
StatusClosed
ResolutionFixed
Resolution Date2011-04-17T01:56:37.000+0000
Affected Version/sn/a
Fix Version/sRelease 1.5.0
ComponentsiOS
Labelsiphone, xml
ReporterBrion Vibber
AssigneeReggie Seagraves
Created2011-04-15T02:57:01.000+0000
Updated2011-09-23T06:25:09.000+0000

Description

TiDomElement.setAttribute is not implemented on iPhone, though it is implemented on Android.

I've implemented it as I need it for my own code:
http://github.com/brion/titanium_mobile/commits/setattribute">http://github.com/brion/titanium_mobile/commits/setattribute
http://github.com/brion/titanium_mobile/commit/acf88afa6d37c51d20960166cbfae21b10cb0896"> http://github.com/brion/titanium_mobile/commit/acf88afa6d37c51d2096...

Note that numerous other unimplemented methods remain!

Comments

  1. Brion Vibber 2011-04-15

    Assigning open patches from StatusNet to our support contact per request.

  2. Brion Vibber 2011-04-15

    Any issues with this patch? Anyone I should be bringing it to for review?

  3. Jeff Haynie 2011-04-15

    merged.

  4. Michael Gangolf 2011-09-23

    patch isn't working for me: var win = Titanium.UI.createWindow({}); var text = "aaa" var xmlDoc = Ti.XML.parseString(text); xmlDoc.documentElement.getElementById('foo0').setAttribute('bar','def'); Ti.API.info(xmlDoc.documentElement.getElementById('foo0').getAttribute("bar")); win.open(); still outputs "abc" and not "def".

JSON Source