[TIMOB-16842] CLI: iOS: Add error checking when parsing developer certs from keychain
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2014-04-18T19:47:04.000+0000 |
Affected Version/s | n/a |
Fix Version/s | 2014 Sprint 08, 2014 Sprint 08 Tooling, Release 3.3.0 |
Components | Tooling |
Labels | module_cli, qe-closed-3.3.0, qe-testadded |
Reporter | Chris Barber |
Assignee | Chris Barber |
Created | 2014-04-11T21:55:15.000+0000 |
Updated | 2014-07-31T18:19:53.000+0000 |
Description
When the iOS detection library is trying to fetch all installed certs, sometimes a cert can't be parsed by node-forge for some reason. We need to add a try/catch around it otherwise a extremely confusing exception is thrown.
Master pull request: https://github.com/appcelerator/titanium_mobile/pull/5594
To test, run "ti info -t ios". The command will no longer crash when a cert is encountered that node-forge can't parse.
No crash, running
Titanium SDK, build 3.3.0.v20140418162516 Node.JS Version: v0.10.13 NPM Version: 1.3.2 ├── acs@1.0.14 ├── alloy@1.3.1 ├── node-appc@0.2.0 ├── npm@1.3.2 ├── titanium@3.2.3-beta2 └── titanium-code-processor@1.1.1-beta1 XCode Version: 5.1.1