[TIMOB-17065] navBarHidden doesn't hide the ActionBar as it suppose to
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Won't Fix |
Resolution Date | 2014-06-04T17:39:12.000+0000 |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | n/a |
Labels | 3.3.0, android |
Reporter | Dan Peleg |
Assignee | Hieu Pham |
Created | 2014-05-23T21:45:20.000+0000 |
Updated | 2017-03-22T22:58:09.000+0000 |
Description
tiapp.xml:
<navbar-hidden>true</navbar-hidden>
app.tss:
"Window": {
navBarHidden: true,
}
And ActionBar (navbar) is still shown.
It only happans on 3.3.0 Alpha+.
The following commit breaks it: [bbf23c59f83eeda97513fdf4e09f2c2bdc1def9c](https://github.com/appcelerator/titanium_mobile/commit/bbf23c59f83eeda97513fdf4e09f2c2bdc1def9c)
Hey, I fixed it on https://github.com/appcelerator/titanium_mobile/pull/5764 I tested and it works. Let me know if anything is missing from the pull request.
Dan, we are removing support for navBarHidden with the implementation of AppCompat. Documentation will be update accordingly. 'navBarHidden' used to hide the title bar, but now since we have full support for ActionBar, this is no longer relevant. Please use the hide() method to hide the actionBar, or you can implement your own appcompat themes for the activities, which is essentially what the above PR does.
When to call
So it the user will never see the title bar ? How can I implement my own theme for all activities ?
Closing ticket as "Won't Fix".