[TIMOB-17761] Launch images for iPhone 6 and 6+ in i18n not copied
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2014-09-26T18:22:10.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 3.4.0, Release 3.5.0 |
Components | iOS |
Labels | i18n, iphone6, iphone6+, qe-3.4.0 |
Reporter | Fokke Zandbergen |
Assignee | Jon Alter |
Created | 2014-09-25T10:38:48.000+0000 |
Updated | 2014-11-21T20:20:47.000+0000 |
Description
The [
titanium-sdk
](https://github.com/appcelerator/titanium_mobile/blob/58198c641d77e17d156431666e80bae732b5c130/node_modules/titanium-sdk/lib/i18n.js#L64) module which is part of the SDK needs to be updated for the new iPhone 6 and 6+ launch images.
*If this is not changed, localized apps will not have launch images on iPhone 6 and 6+, preventing them from publishing for these devices correctly.*
I've created a PR that fixes this and is future proof for other subtypes (h667
) and scales (@3x
) as well:
* master: https://github.com/appcelerator/titanium_mobile/pull/6161
* 3_4_X: https://github.com/appcelerator/titanium_mobile/pull/6166
To test:
1. Create a project
2. Move the launch images from Resources/iphone
to i18n/en
3. Add some text to the iPhone 6 and 6+ images in the new folder
3. Build the project
4. Run on iPhone 6 or 6+ and see it is not showing the i18n images
I reproduced the issue, using Mac osx 10.9.5 Mavericks Appcelerator Studio, build: 3.4.0.201409231834 Titanium SDK, build: 3.4.0.v20140924140915 acs@1.0.16 alloy 1.5.0-rc5 install@0.1.7 npm@1.4.23 sudo@1.0.3 titanium 3.4.0-rc4 titanium-code-processor@1.1.1 Xcode6.0.1 (6A317) Devices: iPhone 6 iOS8 iPhone 6+ iOS 8.0.1
Tested and verified the launch images for iPhone 6 and iPone 6 + are copied Mac osx 10.9.5 Mavericks Appcelerator Studio, build: 3.4.0.201409231834 Titanium SDK, build: 3.4.0.v20140925141714 acs@1.0.16 alloy 1.5.0-rc5 install@0.1.7 npm@1.4.23 sudo@1.0.3 titanium 3.4.0-rc4 titanium-code-processor@1.1.1 Xcode6.0.1 (6A317) Devices: iPhone 6 iOS8 iPhone 6+ iOS 8.0.1