[TIMOB-17785] Having ONLY i18n launch images doesn't work
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2014-09-25T21:25:14.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 3.4.0, Release 3.5.0 |
| Components | iOS |
| Labels | i18n, iphone6, iphone6+, qe-3.4.0 |
| Reporter | Fokke Zandbergen |
| Assignee | Jon Alter |
| Created | 2014-09-25T10:51:45.000+0000 |
| Updated | 2014-11-21T20:20:21.000+0000 |
Description
If you *only* have launch images in i18n folder, including those of the default (
CFBundleDevelopmentRegion or en) language ones, then your app won't show any launch image at all when the phone/simulator is running that default or an unsupported language.
Test case
1. Create a default app 2. Move launch images fromResources/iphone to i18n/en
3. Build the app
4. Run the app to see there is no launch image showing
Cause
This bug was introduced by automatically generatingUILaunchImages keys in Info.plist for TIMOB-17663. It only checks Resources, Resources/iphone and Resources/ios and not the i18n folder for the default language.
Solution
The script should be updated to also search in all or at least the default (CFBundleDevelopmentRegion) locale.
- PR on master: https://github.com/appcelerator/titanium_mobile/pull/6162
- PR on 3_4_x: https://github.com/appcelerator/titanium_mobile/pull/6163
Working on a fix
Added the PRs: - master: https://github.com/appcelerator/titanium_mobile/pull/6162 - 3_4_x: https://github.com/appcelerator/titanium_mobile/pull/6163
Should be tested along with TIMOB-17761
Yeah, was just thinking about that ;)
Thank you [~fokke]!