[TIMOB-18145] iphone module build succeed though there is a missing architecture

GitHub Issue	n/a
Type	Bug
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2015-02-06T20:58:49.000+0000
Affected Version/s	n/a
Fix Version/s	Release 4.0.0
Components	iOS, Tooling
Labels	n/a
Reporter	Praveen Innamuri
Assignee	Feon Sua Xin Miao
Created	2014-12-06T00:27:33.000+0000
Updated	2015-03-19T23:19:19.000+0000

Description

Related to TIMOB-18071. If x86_64 architecture is removed from the manifest, then there is a warning in the build logs, but the build still succeed. However, if any arch is missing for android module, then the build has failed with appropriate warning. We need to address this parity of build between android and iphone platforms.

Comments

Feon Sua Xin Miao 2014-12-12

PR: https://github.com/appcelerator/titanium_mobile/pull/6474 Functional Test: 1. create a module ti create -p all -t module -n test -u http:// --id com.appc.test 2. cd into module iphone directory 3. remove x86_64 architecture from the manifest 3. run ./build.py 4. build should fail with more intuitive error message

   CreateUniversalBinary build/Release-iphonesimulator/libComAppcTest.a normal i386\ x86_64
       cd /Users/feonsua/work/testapps/360/mods/newTestMod/iphone
       export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/Users/feonsua/Library/android-sdk-macosx/tools:/Users/feonsua/Library/android-sdk-macosx/platform-tools"
       /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static /Users/feonsua/work/testapps/360/mods/newTestMod/iphone/build/newTestMod.build/Release-iphonesimulator/newTestMod.build/Objects-normal/i386/libComAppcTest.a /Users/feonsua/work/testapps/360/mods/newTestMod/iphone/build/newTestMod.build/Release-iphonesimulator/newTestMod.build/Objects-normal/x86_64/libComAppcTest.a -o /Users/feonsua/work/testapps/360/mods/newTestMod/iphone/build/Release-iphonesimulator/libComAppcTest.a
   
   ** BUILD SUCCEEDED **
   
   Check build architectures
   
   [WARN] architectures in manifest: i386, arm64, armv7
   [WARN] compiled binary architectures: x86_64, i386, arm64, armv7
   
   MODULE BUILD FAILED
   [ERROR] there is discrepancy between the architectures specified in module manifest and compiled binary.
   [ERROR] Please update manifest to match module binary architectures.

Tim Poulsen 2015-02-06

CR & FR passed, merged
Ewan Harris 2015-03-19

Verified fix on: Mac OSX 10.10.2 Appcelerator Studio, build: 4.0.0.201503171723 Titanium SDK build: 4.0.0.v20150317234215, 4.1.0.v20150319124255 Titanium CLI, build: 4.0.0-alpha Alloy: 1.6.0-alpha Followed the provided test instructions and when an architecture is missing from the manifest the warning is printed out. Closing ticket.

JSON Source