[TIMOB-18287] Windows: CLI - Windows CLI default input font color should not be the same color as PowerShell background
| GitHub Issue | n/a |
|---|
| Type | Improvement |
|---|
| Priority | Low |
|---|
| Status | Closed |
|---|
| Resolution | Fixed |
|---|
| Resolution Date | 2015-06-12T16:58:44.000+0000 |
|---|
| Affected Version/s | n/a |
|---|
| Fix Version/s | Release 4.1.0 |
|---|
| Components | CLI, Windows |
|---|
| Labels | qe-3.5.0 |
|---|
| Reporter | Wilson Luu |
|---|
| Assignee | Dawson Toth |
|---|
| Created | 2014-12-23T22:51:08.000+0000 |
|---|
| Updated | 2017-03-17T17:53:36.000+0000 |
|---|
Description
*Details:* Currently, if you use CLI 3.5.0-dev with SDK 3.6.0 from Windows PowerShell (with default background), the CLI default input font color will match the background color; see attachment.
*Expected:* The CLI default input font color should not match the PowerShell bacgkround.
Attachments
Mind if I take this one, Praveen?
https://github.com/cb1kenobi/fields/pull/7
That was me, by the way. I am the batman.
[The bat signal.](https://s-media-cache-ak0.pinimg.com/736x/8f/30/e7/8f30e79e010f75cf62f01c40a4756760.jpg)
Hmm... my powershell's background color on my mac just changed to be black; not sure what I changed. Might be related to my version of windows 10? But for the magenta stuff, we might consider patching colors.js as follows to get around this...
if (process.platform === 'win32' && process.title.indexOf('PowerShell') >= 0) { String.prototype.__defineGetter__('magenta', String.prototype.__lookupGetter__('red')); }Closing ticket as fixed.