[TIMOB-18344] CLI: the windows subcommand of ti setup should manage the windows.phone.publisherGuid value

GitHub Issue	n/a
Type	Improvement
Priority	None
Status	Closed
Resolution	Fixed
Resolution Date	2015-01-09T15:36:07.000+0000
Affected Version/s	n/a
Fix Version/s	n/a
Components	CLI, Windows
Labels	n/a
Reporter	Tim Poulsen
Assignee	Christopher Williams
Created	2015-01-08T18:09:52.000+0000
Updated	2017-03-23T18:17:20.000+0000

Description

The windows.phone.publisherGuid config setting can currently be set only by using ti config windows.phone.publisherGuid PUBLISHER_GUID. If configured, it is used for Windows Phone / Store builds rather than prompting the developer each time ti build is run. Developers should also be able to configure this value using ti setup and choosing the w (windows) option (or running ti setup windows). Configuring the windows.phone.publisherGuid value should be done in addition to the wp8.publisherGuid value already managed by that subcommand.

Comments

Christopher Williams 2015-01-08

Is there a reason why we wouldn't use the same value for both? I understand one affects Windows Hybrid 8.0 apps and the other Windows Phone / Store 8.1 apps - but I'd assume the developer would use the same publisher GUID for those. Maybe we should use the more generic config key of 'windows.phone.publisherGuid' for both platforms now?
Chris Barber 2015-01-08

[~cwilliams] Sounds good to me. You'll have to update ti setup as well as update https://github.com/appcelerator/titanium_mobile/blob/master/mobileweb/cli/hooks/windows.js#L128 and document the change on https://wiki.appcelerator.org/display/CLI/CLI+Config+Settings.
Tim Poulsen 2015-01-08

That sounds like the right solution to me.
Christopher Williams 2015-01-08

https://github.com/appcelerator/titanium/pull/178 https://github.com/appcelerator/titanium_mobile/pull/6553
Tim Poulsen 2015-01-09

FR passes. It works as expected.
Lee Morris 2017-03-23

Closing ticket as fixed.

JSON Source