[TIMOB-18351] Deprecate iOS and Android modules in node-appc
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-07-14T21:06:48.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 5.0.0 |
Components | CLI |
Labels | n/a |
Reporter | Chris Barber |
Assignee | Feon Sua Xin Miao |
Created | 2015-01-09T04:35:16.000+0000 |
Updated | 2017-03-16T22:08:38.000+0000 |
Description
The iOS and Android versions in node-appc are very old and out-of-date. The logic for these were moved into the Titanium SDK. These modules should be deprecated in node-appc.
However,
ti info
still references this old code when no Titanium SDK is selected or Titanium SDK 3.0/3.1 is selected. Titanium SDK 3.0 & 3.1 requires this code to still exist.
So, this ticket describes the deprecation messages that should be added to the ti info
command as well as deprecation messages whenever Titanium SDK 3.0 or 3.1 is the selected sdk (via config or --sdk
).
Note: there is a separate ticket to remove these modules from node-appc for the Titanium 4 release: TIMOB-18352.
There is no 3.5.0 CLI public release, so moving to 3.5.1.
There was already a warning in
ti info
when using an old SDK version. I made it yellow rather than magenta and updated the text to note the deprecation state. Added a warning inti sdk select
PR: https://github.com/appcelerator/titanium/pull/181 FR steps: 1.ti sdk select
and select a pre-3.2 SDK version, you should get a deprecation warning. 2.ti info
and scroll up through the output to see the notices in the Android and iOS sections. 3. Build a project withti build -p ios
(or android). There's a deprecation warning printed to the console following the "Forking correct SDK command" output. 4.ti sdk select
and select a 3.2+ version. You should not get the deprecation warning. 5. Runti info
and you should not see the notices in the output. (On my system, I got errors, probably due to old/outdated code, unless I used an SDK greater than 3.3)4_0_X: https://github.com/appcelerator/titanium/pull/207
I see the fix but there is an issue: 1. Do
. *You will see no warnings, but you should see them here.* 2. Do
, *you will see the depreciation warnings along with Android & IOS warnings, which is expected.*
. +Android:+
+IOS:+
3. Do
, *you will still see the depreciation warnings as above for 3.1.0.GA SDK which should not be seen as we are selecting 4.0.0 or higher SDK.* 4. If you again do
, you don't see the warnings again. Reopening as part of the fix is not right. Environment: Appc Studio : 4.1.0.201505071004 Ti SDK : 4.1.0.v20150605164428, 4.0.0.GA Ti CLI : 4.0.1 Alloy : 1.6.0 MAC Yosemite : 10.10.3 Appc npm : 4.0.0 Appc CLI : 4.0.2-rc2 Node: v0.10.37 Device - Android 5.0.1
master: https://github.com/appcelerator/titanium/pull/223 4_0_X: https://github.com/appcelerator/titanium/pull/224
PR merged to master.
Closing ticket as fixed.