[TIMOB-18396] CLI: Analytics - CLI analytic events are not sent if you pass --url flag multiple times
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-02-17T15:46:51.000+0000 |
Affected Version/s | Release 3.5.0 |
Fix Version/s | Release 4.1.0 |
Components | CLI |
Labels | qe-3.5.0 |
Reporter | Wilson Luu |
Assignee | Feon Sua Xin Miao |
Created | 2015-01-16T21:48:47.000+0000 |
Updated | 2015-07-07T17:52:34.000+0000 |
Description
*Details:* If you pass --url flag multiple times when creating a project, then the CLI analytic events are not sent.
*Note:* This is *not a regression* as this issue occurs in both CLI 3.4.1 and 3.5.0-dev (from this [commit](https://github.com/appcelerator/titanium/commit/c680bf087d696b0e61fb75eb124a2d24caa17827))
*Steps to reproduce:*
1. From terminal, create a Titanium project with multiple --url flags:
ti create --url bob --url monkeyLord
2. Finish the project creation process
3. Next, go to ~/.titanium/events
*Actual:* A JSON file should be at the directory and if you search for url in the JSON file, you will see an array of the specified urls e.g. \"url\":\[\"bob\",\"monkeyLord\"\]
.
*Expected:* The JSON file should not be there indicating the CLI analytics events were sent.
Per discussion during sprint planning, we should take the last value only when multiples are passed (i.e. only the last value of --url)
PR: https://github.com/appcelerator/titanium_mobile/pull/6643 Follow the steps to reproduce mentioned above, there should be no JSON file under
~/.titanium/events
.CR/FR pass, merged
Closing ticket as fixed. Verified that if you pass
--url
flag multiple times to *Appc CLI*, then CLI analytic events are sent. Tested on: Appc CLI NPM: 4.1.0-1 Appc CLI Core: 4.1.0-5 Arrow: 1.1.0-11 SDK: 4.1.0.v20150706111546 Node: v0.10.38 OS: Yosemite (10.10.4)