[TIMOB-18424] Windows: Improve require implementation
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | None |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-02-05T15:25:59.000+0000 |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | Windows |
Labels | n/a |
Reporter | Christopher Williams |
Assignee | Kota Iguchi |
Created | 2015-01-21T18:25:29.000+0000 |
Updated | 2017-03-14T19:52:27.000+0000 |
Description
We should use a fully implemented algorithm for our require implementation that generally follows the Node.JS spec: http://nodejs.org/api/modules.html#modules_all_together
Tony L has implemented on top of Titanium APis for Ti.current, and Jeff H implemented in Objective-C. We also had an impl in Hyperloop, all of which we can try and re-use leverage.
https://github.com/appcelerator/hyperloop/blob/d61131ff1bf828cc9ecc5672a45ba8627bdba974/lib/ios/jsc/templates/source/Module.m#L228
https://github.com/appcelerator/titanium_mobile_windows/pull/110
Closing ticket as fixed.