[TIMOB-18518] Windows: module generator assumes wrong name for module header file
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-02-06T14:17:06.000+0000 |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | Tooling, Windows |
Labels | n/a |
Reporter | Christopher Williams |
Assignee | Christopher Williams |
Created | 2015-02-05T17:55:37.000+0000 |
Updated | 2017-03-14T05:33:33.000+0000 |
Description
I tried to generate TableViewRow and ran into some issues. First the script failed with:
Generating Titanium.UI.TableViewRow...
Implementing Titanium.UI.TableViewRow...
/Users/cwilliams/repos/titanium_mobile_windows/Tools/Scripts/module_generator/generate.js:357
if (error) throw error;
^
Error: ENOENT, rename '../../../Source/TitaniumKit/include/Titanium/UI.hpp'
That's because the name is UIModule.hpp, not UI.hpp. Some of our modules use the base name (Gesture.hpp), most append "Module" (UIModule.hpp, DatabaseModule.hpp) because the name can't match a neamespace name (i.e. Titanium::Database, Titanium::UI).
The module generate should know when to append Module and when not to (or try looking for WhateverModule.hpp and if that doesn't exist fall back to Whatever.hpp).
Closing ticket as fixed.