[TIMOB-18573] CLI: When build tools are newer than supported range, warn & build rather than fail
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-02-27T04:02:35.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 4.1.0 |
Components | Android, CLI |
Labels | n/a |
Reporter | Tim Poulsen |
Assignee | Tim Poulsen |
Created | 2015-02-13T22:21:40.000+0000 |
Updated | 2015-06-05T21:01:05.000+0000 |
Description
TIMOB-18113 added the ability to specify a specific Android build tools level as well as failing when such tools are newer than the known-supported version. Instead, the tooling should clearly warn the user that they're using a newer version than what is known to work but the build should continue.
PR https://github.com/appcelerator/titanium_mobile/pull/6649 Functional review steps: 1. Create a new project that includes Android as a target 2. From the CLI,
ti build -p android -b
and observe no specific log messages regarding build tools version. 3. Open the folder containing your Android build tools (e.g. ~/android-sdk/build-tools) and copy the newest folder (e.g. the 21.1.0 folder). Name the new folder one full version new (e.g. 22.1.0) 4. From the CLI,ti build -p android -b
and observe the WARN log messages regarding build tools version. These appear at the beginning of the output, following the banner. The app builds as usual (due to the -b flag, it does not launch the emulator or install to a device) 5. Rename the copied build tools folder to something lower than the lowest version (e.g. 12.1.0). 6. From the CLI,ti build -p android -b
and observe no specific log messages regarding build tools version.PR merged.
Verified the fix. We should get this warning if the build tools are newer than the supported range & the build should continue:
The log shows 22.0.1 as I had manually edited the name of the folder but the tools are indeed 22.0.1 Closing. Environment: Appc Studio : 4.1.0.201505071004 Ti SDK : 4.1.0.v20150604094312 CLI : 4.0.2-rc2 Alloy : 1.6.0 MAC Yosemite : 10.10.3 Appc npm : 4.0.0 Appc CLI : 4.0.1 Node: v0.10.37 Nexus 5 - Android 5.1.1