[TIMOB-18748] TiVerify: Should report which module caused license violation
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | None |
| Status | Open |
| Resolution | Unresolved |
| Affected Version/s | Release 3.5.1 |
| Fix Version/s | n/a |
| Components | Tooling |
| Labels | n/a |
| Reporter | Fokke Zandbergen |
| Assignee | Praveen Innamuri |
| Created | 2015-03-27T07:15:27.000+0000 |
| Updated | 2015-03-27T07:15:27.000+0000 |
Description
[~rborn] pointed out that if a project has 20 modules and 1 is causing a license violation, then the error message isn't really helpful to determine *which* module it is:
> License violation detected. Unlicensed module(s) detected. Please contact Appcelerator Support.
The second sentence comes from the server, so this can be fixed server-side.
Relevant code:
* iOS: https://github.com/appcelerator/titanium_verify/blob/302b57da3f73ab6f2d7290f05e3dfdab4de7a028/ios/TiVerify.mm#L195
* Android: https://github.com/appcelerator/titanium_verify/blob/88dd9d677950b2e98f211d1cf5a8b4f699f3119b/android/src/org/appcelerator/titanium/TiVerify.java#L251
No comments