[TIMOB-19096] iOS: ListView new `rowAction` event should be `rowaction` (or `editaction`) like other events
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Low |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2015-08-19T09:18:13.000+0000 |
| Affected Version/s | Release 4.1.0 |
| Fix Version/s | Release 5.0.0 |
| Components | iOS |
| Labels | eventlistener, listview |
| Reporter | Fokke Zandbergen |
| Assignee | Eric Merriman |
| Created | 2015-06-29T13:03:50.000+0000 |
| Updated | 2017-03-20T18:10:08.000+0000 |
Description
The new [rowAction](https://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.ListView-event-rowAction) is camel-cased and though I love that, we have been using all lowercase and we should not mix conventions. So the event should be
rowaction, like the new scrollstart and scrollend on the same ListView API.
It might be even better to name it editaction since that is in line with the Listitem.editActions, ListView.canEdit, ListView.canEdit and ListView.editting property names.
cc [~cng]
[~ingo] if we don't change this now, it will be only more confusing when we change it later. For the same reason I'm happy we could change dividerHeight (TIMOB-19139).
PR Here: https://github.com/appcelerator/titanium_mobile/pull/7044
Approved and merged.
so this is a breaking change for anyone that's implemented this before 5.0. We should deprecate but continue to support 'rowAction' for at least one release and properly message the customers before removing support for it.
Closing ticket as fixed.