Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-19104] Windows: If generating ti.windows.publishername from tiapp publisher value, escape invalid characters

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2015-07-08T18:39:03.000+0000
Affected Version/sRelease 4.1.0
Fix Version/sRelease 5.0.0
ComponentsTooling, Windows
Labelsn/a
ReporterChristopher Williams
AssigneeDawson Toth
Created2015-06-29T19:01:11.000+0000
Updated2015-09-14T20:16:56.000+0000

Description

If there's no explicit ti.windows.publishername value in tiapp we'll default to generating one from the publisher value (which is meant to be the display name). We need to escape invalid characters there (specifically commas) or else the build will fail.

Comments

  1. Christopher Williams 2015-07-01

    http://www.ietf.org/rfc/rfc2253.txt
  2. Christopher Williams 2015-07-01

    https://github.com/appcelerator/titanium_mobile_windows/pull/348
  3. Gary Mathews 2015-07-02

    Re-opened due to : https://github.com/appcelerator/titanium_mobile_windows/pull/348#issuecomment-118128979
  4. Dawson Toth 2015-07-08

    https://github.com/appcelerator/titanium_mobile_windows/pull/366
  5. Ewan Harris 2015-09-14

    Verified using: Windows 8.1 Appc CLI Core: 5.0.0-51 Appc CLI NPM: 4.2.0-8 Titanium SDK : 5.0.0.v20150914103117 Lumia 930 (8.1) When using a name such as Appcelerator, Inc there are no errors thrown Closing ticket

JSON Source