[TIMOB-19131] Windows: Implement Ti.UI.Switch.titleOff and Ti.UI.Switch.titleOn
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2015-08-20T21:35:43.000+0000 |
| Affected Version/s | Release 4.1.0 |
| Fix Version/s | Release 5.0.0 |
| Components | Windows |
| Labels | n/a |
| Reporter | Fokke Zandbergen |
| Assignee | Christopher Williams |
| Created | 2015-07-01T12:42:00.000+0000 |
| Updated | 2015-09-04T01:04:48.000+0000 |
Description
The
OnContent and OffContent properties of the ToggleSwitch used to implement Ti.UI.Switch (TIMOB-18714) have been hard-coded to _On_ and _Off_:
https://github.com/appcelerator/titanium_mobile_windows/blob/master/Source/UI/src/Switch.cpp#L27-L28
They should be set by [Ti.UI.Switch.titleOn](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.Switch-property-titleOn) and [Ti.UI.Switch.titleOff](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.Switch-property-titleOff) like Android and MobileWeb.
Verified the implementation. Closing. Environment: Appc Studio: 4.1.1.201507141126 Ti SDK: 5.0.0.v20150903152019 Ti CLI: 4.1.5 Alloy: 1.7.6 Windows: 8.1 Enterprise 64-bit APPC NPM: 4.2.0-1 APPC CLI: 5.0.0-33 Node : v0.10.37 Device: Nokia Lumia 928 - Windows Phone 8.1 Windows emulator : 8.1