[TIMOB-19175] Windows: Tiapp version isn't populated into app's manifest file
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-07-06T19:18:54.000+0000 |
Affected Version/s | Release 4.1.0 |
Fix Version/s | Release 5.0.0 |
Components | Tooling, Windows |
Labels | n/a |
Reporter | Christopher Williams |
Assignee | Christopher Williams |
Created | 2015-07-06T14:18:07.000+0000 |
Updated | 2015-09-03T00:10:47.000+0000 |
Description
We have a version of 1.1.0.0 hard-coded into the manifest templates. We need to pass along the tiapp version number to the manifest.
From the looks of it, I _think_ the best approach is to use the first two digits from tiapp, and then we should manage the last two. The 3rd one should be an auto-incrementing number each build. The 4th can likely just be a unix timestamp.
https://msdn.microsoft.com/en-us/library/windows/apps/gg442301(v=vs.105).aspx#BKMK_Updatingversionnumbers
http://henrituomola.fi/blog/2013/02/20/auto-versioning-windows-phone-application-packages-using-msbuild/
http://stackoverflow.com/questions/23754398/how-do-i-auto-increment-the-package-version-number
https://github.com/appcelerator/titanium_mobile_windows/pull/354
We should do the same we now (finally) did for iOS like Android and fallback on version but allow the user to override and specify the exact version.
And we should also include Windows in TIMOB-19173, in which case you could do:
Then for windows
3
would replace4
and the 4th would still be a unix timestamp.Verified using: Windows 8.1 Appc CLI Core: 5.0.0-33 Appc CLI NPM: 4.2.0-1 Titanium SDK: 5.0.0.v20150902095518 Nokia Lumia 930 8.1 The version set for an app in the tiapp.xml is now respected and shown when using Ti.App.version Closing ticket