Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-19186] Windows: Optimize Titanium::getAppInfo()

GitHub Issuen/a
TypeImprovement
PriorityNone
StatusClosed
ResolutionFixed
Resolution Date2015-07-08T08:11:06.000+0000
Affected Version/sn/a
Fix Version/sn/a
ComponentsWindows
Labelsn/a
ReporterGary Mathews
AssigneeGary Mathews
Created2015-07-07T19:00:52.000+0000
Updated2017-03-16T22:07:37.000+0000

Description

Currently Titanium::getAppInfo attempts to load _app_info_.json even if previous attempts failed to load it, because it didn't exist.

Comments

  1. Christopher Williams 2015-07-07

    It also loads it multiple times, once per property, rather than just reusing the parsed json.
  2. Gary Mathews 2015-07-07

    It shouldn't
       // Load _app_info_.json
       if (json.IsUndefined()) { // this should stop that happening?
       	json = loadJson(get_context().get_global_object());
       
    PR: https://github.com/appcelerator/titanium_mobile_windows/pull/361
  3. Lee Morris 2017-03-16

    Closing ticket as fixed.

JSON Source