[TIMOB-19314] Android Map doesn't compile with 4.1.0.GA
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-08-05T04:51:46.000+0000 |
Affected Version/s | Release 4.1.0 |
Fix Version/s | Release 4.1.1 |
Components | Android |
Labels | regression |
Reporter | Hieu Pham |
Assignee | Hieu Pham |
Created | 2015-08-04T22:04:38.000+0000 |
Updated | 2015-09-21T18:45:32.000+0000 |
Description
Building map module with 4.1.0.GA result in with this error:
[javac] KrollDict d = ((TiViewProxy) obj).toImage();
[javac] ^
[javac] required: KrollDict
[javac] found: TiBlob
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 1 error
[javac] 10 warnings
This is the result of a method signature change in: https://github.com/appcelerator/titanium_mobile/pull/6907
Reproducible steps:
1. Build the module with 4.1.0.GA and observe the logs.
map PR: https://github.com/appcelerator-modules/ti.map/pull/113 master PR: https://github.com/appcelerator/titanium_mobile/pull/7006 4.1.X PR: https://github.com/appcelerator/titanium_mobile/pull/7007
Updating travis for TiMap https://github.com/appcelerator-modules/ti.map/pull/114
Merged.
Closing ticket as fixed. Verified that I was able to reproduce the original fail case when I reverted https://github.com/appcelerator-modules/ti.map back to commit fbcc395fccd05e4f5a7ee110d6af817e24474330. And, I was able to verify the fix with latest commit on https://github.com/appcelerator-modules/ti.map with SDK 4.1.0.GA. Tested on: https://github.com/appcelerator-modules/ti.map/android Commit: a50dd6418241c10bb24e76e869d96e64fdd9bfb2 SDK: 4.1.0.GA OS: Yosemite (10.10.4)
master PR: https://github.com/appcelerator/titanium_mobile/pull/7050
[~hpham] I'm trying to use ti.map v2.3.3 together with another module that uses the google-play-services library (https://github.com/Sitata/titanium_google_plus) but I cannot compile the app anymore. How do I fix that other module? This is the error: