[TIMOB-19645] CLI: Builder.generateAppIcons ignores existing assets
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | None |
Status | Closed |
Resolution | Invalid |
Resolution Date | 2015-09-30T16:25:09.000+0000 |
Affected Version/s | Release 5.0.0 |
Fix Version/s | n/a |
Components | Tooling, Windows |
Labels | appicon |
Reporter | Kota Iguchi |
Assignee | Eric Merriman |
Created | 2015-09-30T10:59:51.000+0000 |
Updated | 2017-03-23T21:31:41.000+0000 |
Description
Let say we want to create app icons with several sizes and create them during build process like below.
function createAppIconSet(next) {
var appIconSetDir = path.join(this.buildDir, 'Assets'),
missingIcons = [
// Square44x44Logo
{
description: 'Square44x44Logo.png - Used for logo',
file: path.join(appIconSetDir, 'Square44x44Logo.png'),
width: 44,
height: 44,
required: true
},
// Square71x71Logo
{
description: 'Square71x71Logo.png - Used for logo',
file: path.join(appIconSetDir, 'Square71x71Logo.png'),
width: 71,
height: 71,
required: true
},
// Square150x150Logo
{
description: 'Square150x150Logo.png - Used for logo',
file: path.join(appIconSetDir, 'Square150x150Logo.png'),
width: 150,
height: 150,
required: true
}
];
this.generateAppIcons(missingIcons, next);
}
Even when you want to use custom images and place those images in your project (e.g. place custom images under platform/windows/ or project root directory), they are always ignored by the builder during the build.
!vs.png|thumbnail!
Attachments
File | Date | Size |
---|---|---|
vs.png | 2015-09-30T10:57:14.000+0000 | 16959 |
Builder.js is the base class for the WindowsBuilder.js and thus
Builder.generateAppIcon()
is meant to be a utility function. It generates the icons you tell it to. It's not responsible for detecting which icons are missing. That's platform specific. That means your_build.js
must determine what icons exist and which ones are missing. If there are any missing icons, tellBuilder.generateAppIcon()
and it will generate only the icons you told it to.Closing ticket as invalid with reference to the previous comments.