[TIMOB-19650] Windows: Builder.createAppIconSet ignores existing assets
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-10-05T12:40:11.000+0000 |
Affected Version/s | Release 5.0.0 |
Fix Version/s | Release 5.2.0 |
Components | Windows |
Labels | n/a |
Reporter | Kota Iguchi |
Assignee | Gary Mathews |
Created | 2015-09-30T21:03:09.000+0000 |
Updated | 2018-08-06T17:49:27.000+0000 |
Description
Let say we want to create app icons with several sizes and create them during build process like below.
function createAppIconSet(next) {
var appIconSetDir = path.join(this.buildDir, 'Assets'),
missingIcons = [
// Square44x44Logo
{
description: 'Square44x44Logo.png - Used for logo',
file: path.join(appIconSetDir, 'Square44x44Logo.png'),
width: 44,
height: 44,
required: true
},
// Square71x71Logo
{
description: 'Square71x71Logo.png - Used for logo',
file: path.join(appIconSetDir, 'Square71x71Logo.png'),
width: 71,
height: 71,
required: true
},
// Square150x150Logo
{
description: 'Square150x150Logo.png - Used for logo',
file: path.join(appIconSetDir, 'Square150x150Logo.png'),
width: 150,
height: 150,
required: true
}
];
this.generateAppIcons(missingIcons, next);
}
Even when you want to use custom images and place those images in your project (e.g. place custom images under platform/windows/ or project root directory), they are always ignored by the builder during the build.
!vs.png|thumbnail!
Attachments
File | Date | Size |
---|---|---|
vs.png | 2015-09-30T21:02:21.000+0000 | 16959 |
Yeah, we need to be doing the check on our side whether these icon files exist before we add them to the "missingIcons" array we pass to Builder.
PR: https://github.com/appcelerator/titanium_mobile_windows/pull/446
[~gmathews] Does this only work for an alloy project.
Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.