[TIMOB-19674] windowslib: winstore.detect always issues "deployCmd not found" error message

GitHub Issue	n/a
Type	Improvement
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2015-10-06T23:40:58.000+0000
Affected Version/s	Release 5.0.2
Fix Version/s	Release 5.1.0
Components	Tooling, Windows
Labels	n/a
Reporter	Kota Iguchi
Assignee	Kota Iguchi
Created	2015-10-06T05:34:36.000+0000
Updated	2015-10-28T20:11:38.000+0000

Description

appc setup always shows Windows Store SDK is missing the deploy command error message on Windows even when Windows Store SDK is installed. It is because deployCmd variable is not actually used for Windows Store apps but winstore.detect always checks it and issues error message.

$ appc setup
...
The following WINDOWS issues were found in your environment:

        Microsoft Windows Store SDK is missing the deploy command.
        You will be unable to build Windows Store apps.

Some issues were detected for your environment

        Please review the above found issues that were detected for your environment.
        You should resolve these issues before building or running a cross platform app.
        You can re-run setup once they are resolved to validate.

appc setup complete!

I was able to fix it locally, here's a PR: https://github.com/appcelerator/windowslib/pull/23

Comments

Harry Bryant 2015-10-28

*Closing ticket* as fixed, using the latest SDK build (5.1.0.v20151028061258) running "appc setup" returns no errors with Windows SDK installed. Also verified that the edits to winstore.js were present. However it is worth noting that I could not reproduce the error with the affected build (5.0.2) after also verifying that the fix was not present in this build. Windows 10 Pro Microsoft Visual Studio 2015 Ti SDK: 5.1.0.v20151028061258 / 5.0.2.GA Appc NPM: 4.2.1-6 Appc CLI: 5.0.2 / 5.0.4 / 5.1.0-38

JSON Source