[TIMOB-19712] Improve consistency of Ti.UI.iOS.ApplicationShortcuts method names
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2015-10-13T20:59:03.000+0000 |
| Affected Version/s | Release 5.1.0 |
| Fix Version/s | Release 5.1.0 |
| Components | iOS |
| Labels | n/a |
| Reporter | Fokke Zandbergen |
| Assignee | Hans Knöchel |
| Created | 2015-10-11T18:03:02.000+0000 |
| Updated | 2015-10-14T23:11:58.000+0000 |
Description
I think these names (changes in *bold*) would be more consistent:
* *addDynamicShortcut()* (was: addShortcutItem)
* dynamicShortcutExists()
* listDynamicShortcuts()
* listStaticShortcuts()
* removeAllDynamicShortcuts()
* *removeDynamicShortcut()* (was: removeShortcutItem)
FR https://github.com/appcelerator/titanium_mobile/pull/7290 with https://github.com/appcelerator-developer-relations/appc-sample-3dtouch and verified as resolved.
PR (master): https://github.com/appcelerator/titanium_mobile/pull/7290 PR (5_1_X): https://github.com/appcelerator/titanium_mobile/pull/7298
Verified fixed, built demo code with aforementioned name changes to device and launched successfully. Tested on iPhone 6S Plus OSX El Capitan 10.11 Studio: 4.3.1.201509302304 Ti SDK: 5.2.0.v20151014085238 Appc NPM: 4.2.1-1 Appc CLI: 5.1.0-38 Closing Ticket.