[TIMOB-19713] Accept type instead of object with type for dynamicShortcutExists() and removeShortcutItem()
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2015-10-13T20:59:09.000+0000 |
| Affected Version/s | Release 5.1.0 |
| Fix Version/s | Release 5.1.0 |
| Components | iOS |
| Labels | n/a |
| Reporter | Fokke Zandbergen |
| Assignee | Hans Knöchel |
| Created | 2015-10-11T18:28:00.000+0000 |
| Updated | 2015-10-14T23:18:41.000+0000 |
Description
Would it make sense for
dynamicShortcutExists() and removeShortcutItem() to accept a string type as arguments instead of an object with the type as the only property?
Verified fixed by https://github.com/appcelerator/titanium_mobile/pull/7290 with https://github.com/appcelerator-developer-relations/appc-sample-3dtouch
PR (master): https://github.com/appcelerator/titanium_mobile/pull/7290 PR (5_1_X): https://github.com/appcelerator/titanium_mobile/pull/7298
Verified as fixed,
dynamicShortcutExists()&removeShortcutItem()both accept a string type, built app to device and all features work correctly. Tested on iPhone 6S Plus OSX El Capitan 10.11 Studio: 4.3.1.201509302304 Ti SDK: 5.2.0.v20151014085238 Appc NPM: 4.2.1-1 Appc CLI: 5.1.0-38 Closing ticket.