[TIMOB-19715] SDK 5.1.0.CI crashed when run on iOS 8.4
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-10-13T20:59:21.000+0000 |
Affected Version/s | Release 5.1.0 |
Fix Version/s | Release 5.1.0 |
Components | iOS |
Labels | n/a |
Reporter | Fokke Zandbergen |
Assignee | Hans Knöchel |
Created | 2015-10-11T18:38:49.000+0000 |
Updated | 2015-10-16T18:52:41.000+0000 |
Description
An iOS 8.4 Simulator crashes when using 5.1.0 CI, likely due to
Ti.UI.iOS.ApplicationShortcuts
implementation.
*Code*
var win = Titanium.UI.createWindow();
win.open();
*Console* (see attached crash log)
-- Start simulator log -------------------------------------------------------
[INFO] Application started
[DEBUG] Reading stylesheet from: /Users/fokkezb/Library/Developer/CoreSimulator/Devices/874E9320-F223-4096-8A88-626703886ACB/data/Containers/Bundle/Application/5F2D4264-9CB7-44AC-8543-27524DA3242C/windows.app/stylesheet.plist
[TRACE] [ioslib] Detected crash, but no crash file
-- End simulator log ---------------------------------------------------------
The crash log points to:
https://github.com/appcelerator/titanium_mobile/blob/c2f83a627787ea90e936545ecd77f784f1109199/iphone/Classes/TiApp.m#L415-L421
So probably we need a device OS version check as well there. After this has been fixed it needs another test round to see if we haven't got similar code elsewhere.
Attachments
File | Date | Size |
---|---|---|
log.crash | 2015-10-12T07:17:55.000+0000 | 64116 |
I would suggest using the [Ti.UI.iOS.forceTouchSupported](http://appcelerator.github.io/appc-docs/latest/#!/api/Titanium.UI.iOS-property-forceTouchSupported) property and maybe update the docs to use this one. Cool?
Attached crash log
[~hansknoechel] updated the ticket.. it's even happening if you don't use the APIs. It's an implementation error.
Verified fixed using https://github.com/appcelerator/titanium_mobile/pull/7290 with https://github.com/appcelerator-developer-relations/appc-sample-3dtouch which now uses
Ti.UI.iOS.forceTouchSupported
and no longer crashes even when the APIs are not used.PR (master): https://github.com/appcelerator/titanium_mobile/pull/7290 PR (5_1_X): https://github.com/appcelerator/titanium_mobile/pull/7298
Verified as fixed, build a project using the latest 5.1.0 SDK ( 5.1.0.v20151014101225 ) with iOS 8.4 as the target launches successfully. OSX El Capitan 10.11 Studio: 4.3.1.201509302304 Ti SDK: 5.1.0.v20151014101225 Appc NPM: 4.2.1-1 Appc CLI: 5.0.4-2 *Closing ticket.*