[TIMOB-19716] Add support for contact icons to Ti.UI.iOS.ApplicationShortcuts
GitHub Issue | n/a |
---|---|
Type | New Feature |
Priority | None |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2015-10-14T04:28:50.000+0000 |
Affected Version/s | Release 5.1.0 |
Fix Version/s | Release 5.2.0 |
Components | iOS |
Labels | qe-5.2.0 |
Reporter | Fokke Zandbergen |
Assignee | Hans Knöchel |
Created | 2015-10-11T20:34:53.000+0000 |
Updated | 2016-01-22T00:43:09.000+0000 |
Description
We [don't](https://github.com/appcelerator/titanium_mobile/blob/2c2f603d381c43759ac8d30c153d93419ac1aa7c/iphone/Classes/TiUIiOSApplicationShortcutsProxy.m#L176) support the third icon type, which is [iconWithContact](https://developer.apple.com/library/prerelease/ios/documentation/UIKit/Reference/UIApplicationShortcutIcon_Class/index.html#//apple_ref/occ/clm/UIApplicationShortcutIcon/iconWithContact:) atm, which would be nice to add.
PR: https://github.com/appcelerator/titanium_mobile/pull/7299 Demo code: https://gist.github.com/hansemannn/ae779a3287640e1d0b3b
CR and FT passed. PR merged.
Verified fixed, Tested contact icons with demo code provided, working as intended. Tested on: iPhone 6s Plus Device (9.2) Mac OSX El Capitan 10.11 (15A284) Ti SDK: 5.2.0.v20160114021251 Appc NPM: 4.2.3-1 App CLI: 5.2.0-228 Xcode 7.2 Node v4.2.3 *Closing Ticket.*