[TIMOB-20085] Windows: ti clean should cleanup VS temporary build directory
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-03-25T14:04:00.000+0000 |
Affected Version/s | Release 5.1.0 |
Fix Version/s | Release 5.3.0 |
Components | Windows |
Labels | n/a |
Reporter | Kota Iguchi |
Assignee | Kota Iguchi |
Created | 2015-12-02T12:45:36.000+0000 |
Updated | 2016-04-20T21:06:12.000+0000 |
Description
I see that
appc ti clean
and ti clean
command clean up build
directory under your project, but it should have cleaned up VS project temporary build directory (C:\Users\USERNAME\.titanium\vsbuild\YOUR_PROJECT_NAME
too.
https://github.com/appcelerator/titanium_mobile_windows/pull/505
[~cwilliams] [~kota] this needs https://github.com/appcelerator/titanium_mobile/pull/7628 to be backported to 5_3_X Also, I decided to check out master to just check it out the CLI does not appear to be cleaning the temporary build directory, I don't see any logging informing me of the deletion as seen in the code and also the folder is still present. I am using SDK version 5.4.0.v20160322115854
I need to revisit this. Re-opening...
Found out that
alloy
prevents from running platform-specificclean
hook. https://github.com/appcelerator/alloy/pull/772 Note: This needs https://github.com/appcelerator/titanium_mobile/pull/7628 to be backported to5_3_X
Cherry-picked the fix for titanium_mobile over to 5_3_X branch and merged the fix for Alloy.
Verified using: Windows 10 Pro Visual Studio 2015 Community Update 2 Appc Core: 5.3.0-26 Appc NPM: 4.2.5-3 Ti SDK: 5.3.0.v20160420090405 When running
appc ti clean
on both a classic and alloy project, both the local build directory and the build directory in .titanium\vsbuild are deleted Closing ticket