[TIMOB-20174] iOS: Move Ti.UI.iPhone.* namespaces to Ti.UI.iOS.*
GitHub Issue | n/a |
Type | Improvement |
Priority | Low |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-07-12T16:48:04.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 5.4.0 |
Components | iOS |
Labels | n/a |
Reporter | Hans Knöchel |
Assignee | Angel Petkov |
Created | 2015-12-23T19:48:25.000+0000 |
Updated | 2017-05-30T16:51:04.000+0000 |
Description
For the release 6.0.0, we should clean up the Ti.UI.iPhone.\*
namespace and move components, that are also available on the iPad, to Ti.UI.iOS.\*
instead and deprecate the old ones:
*Modules*:
- Ti.UI.iPhone.ActivityIndicatorStyle
-- Already moved to Ti.UI.ActivityIndicatorStyle (TIMOB-19522)
- Ti.UI.iPhone.AlertDialogStyle
-- Move to Ti.UI.iOS.AlertDialogStyle
- Ti.UI.iPhone.AnimationStyle
-- Move to Ti.UI.iOS.AnimationStyle
- Ti.UI.iPhone.ListViewCellSelectionStyle
-- Move to Ti.UI.iOS.ListViewCellSelectionStyle
- Ti.UI.iPhone.ListViewScrollPosition
-- Move to Ti.UI.iOS.ListViewScrollPosition
- Ti.UI.iPhone.ListViewSeparatorStyle
-- Move to Ti.UI.iOS.ListViewSeparatorStyle
- Ti.UI.iPhone.ListViewStyle
-- Move to Ti.UI.iOS.ListViewStyle
- Ti.UI.iPhone.NavigationGroup
-- Remove API from docs in 6.0.0, removed since 3.2.0
- Ti.UI.iPhone.ProgressBarStyle
-- Move to Ti.UI.iOS.ProgressBarStyle
- Ti.UI.iPhone.RowAnimationStyle
-- Move to Ti.UI.iOS.RowAnimationStyle
- Ti.UI.iPhone.ScrollIndicatorStyle
-- Move to Ti.UI.iOS.ScrollIndicatorStyle
- Ti.UI.iPhone.StatusBar
-- Move to Ti.UI.iOS.StatusBar
- Ti.UI.iPhone.SystemButton
-- Move to Ti.UI.iOS.SystemButton
- Ti.UI.iPhone.SystemButtonStyle
-- Move to Ti.UI.iOS.SystemButtonStyle
- Ti.UI.iPhone.SystemIcon
-- Move to Ti.UI.iOS.SystemIcon
- Ti.UI.iPhone.TableViewCellSelectionStyle
-- Move to Ti.UI.iOS.TableViewCellSelectionStyle
- Ti.UI.iPhone.TableViewScrollPosition
-- Move to Ti.UI.iOS.TableViewScrollPosition
- Ti.UI.iPhone.TableViewSeparatorStyle
-- Move to Ti.UI.iOS.TableViewSeparatorStyle
- Ti.UI.iPhone.TableViewStyle
-- Move to Ti.UI.iOS.TableViewStyle
*Properties*:
- Ti.UI.iPhone.appBadge
-- Move to Ti.UI.iOS.appBadge
- Ti.UI.iPhone.appSupportsShakeToEdit
-- Move to Ti.UI.iOS.appSupportsShakeToEdit
- Ti.UI.iPhone.statusBarHidden
-- Remove in 6.0.0, deprecated since 3.1.3, replaced with "fullscreen" on window
- Ti.UI.iPhone.statusBarStyle
-- Remove in 6.0.0, deprecated since 3.1.3, replaced with "statusBarStyle" on window
*Constants*:
- Ti.UI.iPhone.MODAL_PRESENTATION_*
-- Move to Ti.UI.iOS.MODAL_PRESENTATION_*
- Ti.UI.iPhone.MODAL_TRANSITION_STYLE_*
-- Move to Ti.UI.iOS.MODAL_TRANSITION_STYLE_*
Attachments
PR:https://github.com/appcelerator/titanium_mobile/pull/7662
[~apetkov] [~hansknoechel] because this ticket is already merged into master and we are moving master to be 5.4.0, I need to confirm with you guys if there's any *BREAKING* changes in this PR. From the looks of it, *there isn't*. Am I correct to say: 1. there's no *REAL removal* of any methods and properties 2. if i use any Ti.UI.iPhone.\* it will *still work* and all that the macros does is just prompt to say that this is deprecated and removed ?
You are correct. This ticket only deprecated the iPhone namespace and instroduces the new one, it does not remove anything. To bring it into 5.4.0, we would need to adjust the adjust the docs and logs from 6.0.0 to 5.4.0. *EDIT*: We leave it like it is.
Kiat, shouldn't this ticket should be in 5.4.0 - at least from the code-changes already applied? (!)
Reopening because of missing deprecations and usage-updates.
PR (master): https://github.com/appcelerator/titanium_mobile/pull/8125 PR (5_4_X): https://github.com/appcelerator/titanium_mobile/pull/8126
Closing ticket as fixed.