[TIMOB-20201] Windows: Enable SAFESEH for Windows 10 x86 build
GitHub Issue | n/a |
---|---|
Type | Story |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-01-06T21:24:07.000+0000 |
Affected Version/s | Release 5.1.0 |
Fix Version/s | Release 5.3.0 |
Components | Windows |
Labels | n/a |
Reporter | Kota Iguchi |
Assignee | Kota Iguchi |
Created | 2016-01-06T04:37:00.000+0000 |
Updated | 2016-05-18T22:25:35.000+0000 |
Description
We have been disabling
SAFESEH
linker option just to supress compiler warning message for simulator according to [HAL/CMakeLists.txt#L195](https://github.com/appcelerator/HAL/blob/master/CMakeLists.txt#L195).
Since SAFESEH option is only available on x86 build, it has been a no problem before because it only affects on the simulator. But in the Windows 10 world, we could have x86 app for the Store App, and disabling SAFESEH won't pass the Windows App Certification for x86. We should enable it again even on x86 build.
https://github.com/appcelerator/titanium_mobile_windows/pull/525
[~kota] How can we test this?