Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-20201] Windows: Enable SAFESEH for Windows 10 x86 build

GitHub Issuen/a
TypeStory
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2016-01-06T21:24:07.000+0000
Affected Version/sRelease 5.1.0
Fix Version/sRelease 5.3.0
ComponentsWindows
Labelsn/a
ReporterKota Iguchi
AssigneeKota Iguchi
Created2016-01-06T04:37:00.000+0000
Updated2016-05-18T22:25:35.000+0000

Description

We have been disabling SAFESEH linker option just to supress compiler warning message for simulator according to [HAL/CMakeLists.txt#L195](https://github.com/appcelerator/HAL/blob/master/CMakeLists.txt#L195). Since SAFESEH option is only available on x86 build, it has been a no problem before because it only affects on the simulator. But in the Windows 10 world, we could have x86 app for the Store App, and disabling SAFESEH won't pass the Windows App Certification for x86. We should enable it again even on x86 build.

Comments

  1. Kota Iguchi 2016-01-06

    https://github.com/appcelerator/titanium_mobile_windows/pull/525
  2. Eric Merriman 2016-05-18

    [~kota] How can we test this?

JSON Source