[TIMOB-20250] Hyperloop: Cannot remove a HyperloopViewProxy from a TiViewProxy
GitHub Issue | n/a |
---|---|
Type | Story |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-04-26T17:33:23.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 5.4.0 |
Components | Hyperloop, iOS |
Labels | hyperloop, proxy |
Reporter | Hans Knöchel |
Assignee | Pedro Enrique |
Created | 2016-01-19T22:27:35.000+0000 |
Updated | 2017-03-16T22:50:34.000+0000 |
Description
We added support for adding a
HyperloopViewProxy
to the Titanium view hierarchy, but not for removing them again. We should do a similar check like [here](https://github.com/appcelerator/titanium_mobile/blob/master/iphone/Classes/TiViewProxy.m#L191) to get the TiViewProxy
correctly.
The thrown error: Invalid type passed to function. expected: TiViewProxy, was: HyperloopClass -\[TiViewProxy remove:\] (TiViewProxy.m:266)
[~penrique] Thinking about this issue, would it make sense to check for the HyperloopViewProxy [here](https://github.com/appcelerator/titanium_mobile/blob/master/iphone/Classes/TiViewProxy.m#L286) and call
setNativeView:nil
to reset the native view?PR: https://github.com/appcelerator/titanium_mobile/pull/7956
Demo:
Closing ticket as fixed.