[TIMOB-20298] Classic Titanium app with tabs crashes when closed on iOS
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-02-05T17:42:03.000+0000 |
Affected Version/s | Release 5.1.2 |
Fix Version/s | Release 5.2.0 |
Components | iOS, TiAPI |
Labels | n/a |
Reporter | Chris Linseman |
Assignee | Angel Petkov |
Created | 2016-02-01T20:21:04.000+0000 |
Updated | 2016-02-05T22:52:18.000+0000 |
Description
When a classic titanium app with tabs is closed on iOS it crashes.
*Steps to reproduce:*
1) Create a new mobile app: Classic -> Tabbed Application
2) Run the app on iOS Simulator
3) Double tap the home icon to bring up the app selection/multitasking screen
4) Close the app by sliding it up
*Expected result*
App closes normally, without an exception
*Actual result*
Console displays:
[ERROR] : Can not close root window of the tab. Use removeTab instead
It seems like the problem is occurring [here](https://github.com/appcelerator/titanium_mobile/blob/master/iphone/Classes/TiUITabProxy.m#L275)
PR pending: https://github.com/appcelerator/titanium_mobile/pull/7676/files
Anyway we can get this into 5.2 would make huge strides for the customer. +1 from my side to do so!
Great!
[~apetkov] We need this in 5.2.0 so please do a back port as well.
PR (master): https://github.com/appcelerator/titanium_mobile/pull/7686 PR (5_2_X): https://github.com/appcelerator/titanium_mobile/pull/7685 Cherry-picked Angel's commits and added one to ensure a proper logging while running on kroll thread.
Verified fixed, using: MacOS 10.11.3 (15D21) Studio 4.5.0.201602050824 Ti SDK 5.2.0.v20160205071936 Appc NPM 4.2.3-1 Ti CLI 5.0.6 Alloy 1.7.33 Xcode 7.2 (7C68) Tabbed applications can be closed/killed without throwing an error or warning. Tested with several sample app templates.