[TIMOB-20391] Parity: Separator style properties for TableView and ListView not aligned
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-07-12T08:49:55.000+0000 |
Affected Version/s | Release 5.2.0 |
Fix Version/s | Release 5.4.0 |
Components | Android, iOS, MobileWeb |
Labels | parity |
Reporter | Fokke Zandbergen |
Assignee | Chee Kiat Ng |
Created | 2016-02-11T16:04:21.000+0000 |
Updated | 2018-10-10T16:30:01.000+0000 |
Description
This looks a bit messy:
* In 5.2 we introduce [Ti.UI.TABLE_VIEW_SEPARATOR_STYLE_NONE](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI-property-TABLE_VIEW_SEPARATOR_STYLE_NONE) and [Ti.UI.TABLE_VIEW_SEPARATOR_STYLE_SINGLE_LINE](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI-property-TABLE_VIEW_SEPARATOR_STYLE_SINGLE_LINE) for Android and iOS but the descriptions don't say where you can use these.
* [Ti.UI.TableView.separatorStyle](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.TableView-property-separatorStyle) still says for iOS you should use [Ti.UI.iPhone.TableViewSeparatorStyle.NONE/SINGLE_TINE](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.iPhone.TableViewSeparatorStyle) and for MobileWeb [Ti.UI.MobileWeb.TableViewSeparatorStyle.NONE/SINGLE_LINE](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.MobileWeb.TableViewSeparatorStyle)
* [Ti.UI.ListView.separatorStyle](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.ListView-property-separatorStyle) says it's iOS only and you should use [Ti.UI.iPhone.TableViewSeparatorStyle.NONE/SINGLE_TINE](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.iPhone.TableViewSeparatorStyle)
I'd suggest:
* We create
Ti.UI.LIST_SEPARATOR_STYLE_*
(like we have [Ti.UI.ACCESSORY_TYPE_*](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI-property-LIST_ACCESSORY_TYPE_NONE)) for iOS, Android and MobileWeb
* We let Ti.UI.TableView.separatorStyle
and Ti.UI.ListView.separatorStyle
use these for iOS, Android and MobileWeb
* We deprecate Ti.UI.TABLE_VIEW_SEPARATOR_STYLE*
, Ti.UI.iPhone.TableViewSeparatorStyle
and Ti.UI.MobileWeb.TableViewSeparatorStyle
* We extend support for Ti.UI.ListView.separatorStyle
to Android
/cc [~bimmel] since it's partly doc-related
[~fokkezb], Added to the SDK 5.2.0 Beta release notes though I may have to pull it and put it in the RC release notes if it doesn't get resolved before the beta gets released.
Fixed as part of TIMOB-20174. Cleaned-up the constants.