[TIMOB-20451] Window.close should use new activity*Transition instead of activity*Animation or default
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-04-28T06:58:28.000+0000 |
Affected Version/s | Release 5.2.0 |
Fix Version/s | Release 5.4.0 |
Components | Android |
Labels | n/a |
Reporter | Fokke Zandbergen |
Assignee | Srikanth Sombhatla |
Created | 2016-02-24T12:22:51.000+0000 |
Updated | 2016-07-14T22:25:24.000+0000 |
Description
With TIMOB-19580 we have introduced
activity*Transition
properties for Ti.UI.Window
.
We also still have activity*Animation
properties for Ti.UI.Window.open()
and Ti.UI.Window.close()
.
The Issue
This is confusing, but also seems to not always work as expected: If you try the _Activity Transitions_ example in the [Ti 5.2.0 Sample App](https://github.com/appcelerator-developer-relations/appc-sample-ti520) and set allactivity*Transition
properties to TRANSITION_NONE
you will see that if you use the system navigation bar (or hardware) back button in Window B it will indeed close without animation. But if you use the Action Bar Level Up icon (which simply calls Ti.UI.Window.close()
) it will fade out.
Solution
We should: 1. Make sure that if I callTi.UI.Window.close()
without activityEnterAnimation
and activityExitAnimation
, it will honour Ti.UI.Window.activityReturnTransition
.
2. Deprecate and in 6.0 remove the activity*Animation
properties.
PR: https://github.com/appcelerator/titanium_mobile/pull/7961 Using
Ti.UI.Window.close()
or device back should close with transition.We should move this to 5.4.0
PR merged
Thanks [~ssombhatla]! [~msamah] The PR deals with #1 - what are your thoughts on #2? * Deprecate and in 6.0 remove the
activity*Animation
properties.[~msamah], I have verified the fix for #1, & as [~fokkezb] commented are we doing anything for #2. I am gonna leave it resolved as the fix is just for #1 as of now. Environment: Appc Studio : 4.6.0.201605201934 Ti SDK : 5.4.0.v20160608165242 Ti CLI : 5.0.8 Alloy : 1.8.7 MAC El Capitan : 10.11.4 Appc NPM : 4.2.7-2 Appc CLI : 5.4.0-11 Node: 4.4.4 Nexus 6 - Android 6.0.0
Closing.