[TIMOB-20591] iOS: Rename "tableSeparatorInsets" to "listSeparatorInsets" in Ti.UI.ListView
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2016-03-18T18:49:40.000+0000 |
| Affected Version/s | Release 5.2.0 |
| Fix Version/s | Release 5.4.0 |
| Components | iOS |
| Labels | listview, qe-5.4.0, separatorinsets |
| Reporter | Hans Knöchel |
| Assignee | Hans Knöchel |
| Created | 2016-03-18T12:15:56.000+0000 |
| Updated | 2016-06-10T20:42:23.000+0000 |
Description
As discussed in TIMOB-16355, we should follow the
list-prefix for alle ListView methods just like ListSection and ListItem etc. So we should rename tableSeparatorInsets to listSeparatorInsets, thats it.
PR: https://github.com/appcelerator/titanium_mobile/pull/7864
Demo code
var win = Ti.UI.createWindow({ backgroundColor: '#fff' }); var sections = []; var sectionFruit = Ti.UI.createListSection({ headerTitle: 'Fruit headerTitle',}); var fruitDataSet = [ {properties: { title: 'Apple'}}, {properties: { title: 'Banana'}}, ]; sectionFruit.setItems(fruitDataSet); sections.push(sectionFruit); var sectionVeg = Ti.UI.createListSection({ headerTitle: 'Vegetables headerTitle'}); var vegDataSet = [ {properties: { title: 'Carrots'}}, {properties: { title: 'Potatoes'}}, ]; sectionVeg.setItems(vegDataSet); sections.push(sectionVeg); var listView = Ti.UI.createListView({ top: 20, headerTitle: 'Table headerTitle', footerTitle: 'Table footerTitle', tableSeparatorInsets: { left: 50, right: 50 }, rowSeparatorInsets: { left: 30, right: 30 }, }); listView.sections = sections; win.add(listView); win.open();Verified as fixed, listSeparatorInsets work correctly, and using tableSeparatorInsets returns a Deprecation warning. Tested On: iPhone 6S (9.3.2) Device & iPhone 6 Plus (8.3) Device Mac OSX El Capitan 10.11.5 Ti SDK: 5.4.0.v20160608165242 Appc Studio: 4.6.0.201605201934 Appc NPM: 4.2.7-2 App CLI: 5.4.0-15 Xcode 7.3 Node v4.2.6 *Closing ticket.*