Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-2268] TiUIiPhoneNavigationGroup "close" method ignore "properties.animation".

GitHub Issuen/a
TypeBug
PriorityTrivial
StatusClosed
ResolutionFixed
Resolution Date2011-04-17T01:58:36.000+0000
Affected Version/sn/a
Fix Version/sRelease 1.5.0
ComponentsiOS
Labelsn/a
Reporteryevhene
AssigneeReggie Seagraves
Created2011-04-15T03:15:12.000+0000
Updated2011-04-17T01:58:36.000+0000

Description

titanium_mobile / iphone / Classes / TiUIiPhoneNavigationGroup.m
...

-(void)close:(TiWindowProxy)window withObject:(NSDictionary)properties {

UIViewController* windowController = [window controller];
NSMutableArray* newControllers = [NSMutableArray arrayWithArray:controller.viewControllers];
BOOL animated = (windowController == [newControllers lastObject]);
[newControllers removeObject:windowController];
[controller setViewControllers:newControllers animated:animated];

[window retain];
[window close:nil];
[window autorelease];

} ...

"animated" value should be overridable by "properties.animation".

Comments

  1. Stephen Tramer 2011-04-15

    Fixed by pull request https://github.com/appcelerator/titanium_mobile/pull/19">https://github.com/appcelerator/titanium_mobile/pull/19, in commit 60d39d.

  2. Jeff Haynie 2011-04-15

    (from [24cf21112c54897ca5af843e9eaaf89a2315fb5a]) [#2268] Test for popping top nav window without animation. https://github.com/appcelerator/titanium_mobile/commit/24cf21112c54897ca5af843e9eaaf89a2315fb5a"> https://github.com/appcelerator/titanium_mobile/commit/24cf21112c54...

  3. Blain Hamon 2011-04-15

    Indeed, this allows turning off animations in KS now.

JSON Source