[TIMOB-23248] Windows: module project cmake generator should select VS version accordingly
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-04-21T23:22:34.000+0000 |
Affected Version/s | Release 5.4.0 |
Fix Version/s | Release 5.3.0 |
Components | Windows |
Labels | n/a |
Reporter | Kota Iguchi |
Assignee | Kota Iguchi |
Created | 2016-04-20T13:58:07.000+0000 |
Updated | 2016-05-25T20:30:41.000+0000 |
Description
Currently if you need to create module project for VS 2013, you need to run
ti create -p windows -t module --wp-sdk 8.1
. Unfortunately appc new --wp-sdk 8.1 ...
doesn't work in this case. But basically Titanium CLI should be able to select appropriate VS version accordingly without demanding user input.
So on appc new
or ti create
, CLI should select VS version accordingly:
- When user installs VS 2013 only, cmake VS 2013 generator should be selected
- When user installs VS 2015 only, cmake VS 2015 generator should be selected
- When user installs both VS 2015 and VS 2013, cmake VS 2015 generator should be selected because it's newer
https://github.com/appcelerator/titanium_mobile_windows/pull/641
https://github.com/appcelerator/titanium_mobile_windows/pull/652
[~kota] This fix is present in the latest 5.3.0 build 5.3.0.v20160523083840 could the fixVersion be amended to reflect this? Thanks!
Verified using: Windows 10 Pro Visual Studio 2015 Community Update 2 Appc Core: 5.3.0-46 Appc NPM: 4.2.5-5 Ti SDK: 5.3.0.v20160523083840 Lumia 520 8.1, Lumia 930 10.0 When creating a module using
appc new -t timodule -n module --i com.module
with the above config, the creation is now successful and the correct vs version is used Closing ticket