[TIMOB-23279] Windows: Omit invalid devices from wptool detection
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-07-14T22:59:45.000+0000 |
Affected Version/s | windowslib 0.4.9 |
Fix Version/s | Release 6.0.0, windowslib 0.4.15 |
Components | Windows |
Labels | n/a |
Reporter | Gary Mathews |
Assignee | Gary Mathews |
Created | 2016-04-27T02:21:35.000+0000 |
Updated | 2016-10-05T16:09:14.000+0000 |
Description
wptool.js always reports a device, even if there is not one connected
{
"name": "Device",
"udid": 0,
"index": 0,
"wpsdk": null
}
The wptool binary does not omit any invalid devices, this is reported when no device is connected or when two devices are connected.
{
"name": "Device",
"udid": 0,
"index": 0,
"version": "2147483647.2147483647.2147483647.2147483647",
"wpsdk": null
}
PR: https://github.com/appcelerator/windowslib/pull/42
[~cwilliams] Could you review this? Is this still valid [~gmathews]?
[~kota] Yes, this is still valid
[~gmathews] I tried this locally, and
ti info -p windows -o json
gives me following result. *When a device is connected*This looks good.(y) *When no device is connected*
Is this expected result? Do we want to show this place holder device when no device is connected? > [~gmathews] If so, could you push a PR to
titanium_mobile
to request bump up the version forwindowslib
? Thanks.titanium_mobile: https://github.com/appcelerator/titanium_mobile/pull/8138
[~gmathews] Is it ok to make this ticket be "resolved" while [windowslib/pull/49](https://github.com/appcelerator/windowslib/pull/49) is still open?
Verified using: OS: Microsoft Windows 10 Pro 10.0.14393 Appc core: 6.0.0-56 Appc NPM: 4.2.8-7 Ti SDK: 6.0.0.v20161004202820 Appc Studio: 4.8.0.201609292239 When no device is connected
ti info -t windows
andti info -t windows -o json
no longer report the placeholder device Closing ticket