[TIMOB-23279] Windows: Omit invalid devices from wptool detection

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2016-07-14T22:59:45.000+0000
Affected Version/s	windowslib 0.4.9
Fix Version/s	Release 6.0.0, windowslib 0.4.15
Components	Windows
Labels	n/a
Reporter	Gary Mathews
Assignee	Gary Mathews
Created	2016-04-27T02:21:35.000+0000
Updated	2016-10-05T16:09:14.000+0000

Description

wptool.js always reports a device, even if there is not one connected

{
  "name": "Device",
  "udid": 0,
  "index": 0,
  "wpsdk": null
 }

The wptool binary does not omit any invalid devices, this is reported when no device is connected or when two devices are connected.

{
  "name": "Device",
  "udid": 0,
  "index": 0,
  "version": "2147483647.2147483647.2147483647.2147483647",
  "wpsdk": null
 }

Comments

Gary Mathews 2016-04-27

PR: https://github.com/appcelerator/windowslib/pull/42
Kota Iguchi 2016-05-09

[~cwilliams] Could you review this? Is this still valid [~gmathews]?
Gary Mathews 2016-05-10

[~kota] Yes, this is still valid

Kota Iguchi 2016-07-13

[~gmathews] I tried this locally, and ti info -p windows -o json gives me following result. *When a device is connected*

   "devices": [
           {
                   "name": "Lumia 630 Dual SIM (RM-978)",
                   "udid": "00000015-4901-3b2b-0000-000000000000",
                   "index": 0,
                   "wpsdk": "8.1",
                   "ip": "127.0.0.1"
           }
   ]

This looks good.(y) *When no device is connected*

   "devices": [
           {
                   "name": "Device",
                   "udid": 0,
                   "index": 0,
                   "wpsdk": null
           }
   ],

Is this expected result? Do we want to show this place holder device when no device is connected? > [~gmathews] If so, could you push a PR to titanium_mobile to request bump up the version for windowslib? Thanks.

Gary Mathews 2016-07-14

titanium_mobile: https://github.com/appcelerator/titanium_mobile/pull/8138
Kota Iguchi 2016-08-01

[~gmathews] Is it ok to make this ticket be "resolved" while [windowslib/pull/49](https://github.com/appcelerator/windowslib/pull/49) is still open?
Ewan Harris 2016-10-05

Verified using: OS: Microsoft Windows 10 Pro 10.0.14393 Appc core: 6.0.0-56 Appc NPM: 4.2.8-7 Ti SDK: 6.0.0.v20161004202820 Appc Studio: 4.8.0.201609292239 When no device is connected ti info -t windows and ti info -t windows -o json no longer report the placeholder device Closing ticket

JSON Source