Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23448] SDK: Set Node 4.X as minimum supported version

GitHub Issuen/a
TypeImprovement
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2016-07-20T01:02:41.000+0000
Affected Version/sn/a
Fix Version/sRelease 6.0.0, titanium 5.0.9, titanium 5.0.10
ComponentsTooling
Labelsbreaking-change
ReporterTim Poulsen
AssigneeFeon Sua Xin Miao
Created2016-05-27T16:00:01.000+0000
Updated2018-08-06T17:49:11.000+0000

Description

Update the minimum supported version of Node to 4.x. Make sure to check for and update any version checks in the code as well as updating the package.json file.

Comments

  1. Feon Sua Xin Miao 2016-07-19

    PR: https://github.com/appcelerator/titanium_mobile/pull/8144 https://github.com/appcelerator/titanium/pull/250
  2. Chee Kiat Ng 2016-07-20

    APPROVED and merged!
  3. Kondal Kolipaka 2016-07-29

    [~fmiao] [~cng] - What is the minimum required node version to work with SDK 6.0 - is it node v4 or v5? In this ticket, we are setting 4.x as miniumum version but below error says node.js v5 
       !MESSAGE (Build 4.8.0.qualifier) [ERROR]  Titanium SDK 6.0.0.v20160717220907 is incompatible with Node.js v0.12.7
   You will need to install Node.js v5 in order to use this version of the Titanium SDK.
  4. Chee Kiat Ng 2016-07-29

    4. what...?
  5. Chris Barber 2016-07-29

    It should be Node.js 4.2.0 through the latest 4.x (currently 4.4.7).
  6. Feon Sua Xin Miao 2016-08-01

    The range is set here: https://github.com/appcelerator/titanium_mobile/blob/master/package.json#L73
  7. Chee Kiat Ng 2016-08-02

    [~fmiao] So you are saying what Kondal is seeing is accurate? Then do you think we should do this instead? "node": ">=4.0 <=5.x" to "node": ">=4.0 <5.0" ?
  8. Chee Kiat Ng 2016-08-02

    [~ingo] thoughts? ^
  9. Kondal Kolipaka 2016-08-02

    [~fmiao][~cng] - https://github.com/appcelerator/titanium/blob/5d22ac5bc272c95bca558857ce0fc15f494af58a/lib/titanium.js#L415 Message is misleading; 
        logger.log(__('You will need to install Node.js %s in order to use this version of the Titanium SDK.', 'v' + appc.version.parseMax(sdk.packageJson.vendorDependencies.node)));
    I think better way would be, showing minimum and maximum version supported.
  10. Chris Barber 2016-08-02

    Agreed. Why don't we do like we do for other things like Xcode versions where if the version is too old we say "You must run version X or newer" and if it's too new we say "It's too new and things may not work, good luck."
  11. Eric Merriman 2018-08-06

    Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.

JSON Source