[TIMOB-23468] Hyperloop: Update npm dependencies
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2019-03-20T18:03:43.000+0000 |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | Hyperloop |
Labels | n/a |
Reporter | Hans Knöchel |
Assignee | Jan Vennemann |
Created | 2016-06-02T08:12:16.000+0000 |
Updated | 2019-03-20T18:07:40.000+0000 |
Description
For the stable release, we should stick to best practices and not deliver new software that has deprecated dependencies. In our case, we currently use (both) wrench 1.5.8 and 1.5.9 as well as graceful 1.2.3
npm WARN deprecated wrench@1.5.9: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.
npm WARN deprecated wrench@1.5.8: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.
npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
So proposal: Remove wrench with fs-extra (which has a 90 % same API) and upgrade graceful-fs to 4.0.0. We need to check the ocurrences and use-cases related to their calls, but it should not be too hard to replace.
While the original description is no longer relevant the used node packages should be updated throughout the project. Used package.json files that require updating: * android/hooks/package.json * iphone/hooks/package.json * packages/hyperloop-ios-metabase/package.json (not used anymore, leaving untouched) * package.json
PR: https://github.com/appcelerator/hyperloop.next/pull/317
[~spulipakkam], I agree with Jan, it has been released already. We didn't see any issues during smokes. I'll close it.