Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23496] TiAPI: Deprecate old Geolocation properties, add more parity

GitHub Issuen/a
TypeImprovement
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2019-01-09T18:27:55.000+0000
Affected Version/sn/a
Fix Version/sRelease 8.0.0
ComponentsAndroid, iOS, TiAPI, Windows
Labelsparity
ReporterChristopher Williams
AssigneeChristopher Williams
Created2016-06-10T19:08:45.000+0000
Updated2019-01-09T18:27:59.000+0000

Description

http://docs.appcelerator.com/platform/latest/#!/api/GeocodedAddress Specifically, it is insane that we: - have a postalCode property on Android, but zipcode on iOS/Windows. - latitude and longitude are Numbers on iOS/Windows, but String on Android. - have both country_code (on all platforms), and countryCode (only on Android) (we should likely have the same property, and given our naming scheme, it should be called "countryCode")

Comments

  1. Kota Iguchi 2016-12-19

    These GeocodedAddess values are the JSON values originally what api.appcelerator.net returns on Windows/iOS. I expect this can be resolved when Android Ti.Geolocation implementation uses api.appcelerator.net too.
  2. Hans Knöchel 2017-01-10

    [~mchen] Is this something you would like to work on? Basically, it's about better parity across the platforms. I think the problem is that we cannot just remove any property from the result, so we would either need to put it into 7.0.0 together with a special (docs) note or we return both for now.
  3. Maggie Chen 2017-02-16

    PR https://github.com/appcelerator/titanium_mobile/pull/8823
  4. Hans Knöchel 2017-12-01

    PR (master): https://github.com/appcelerator/titanium_mobile/pull/9647 PR (7_0_X): https://github.com/appcelerator/titanium_mobile/pull/9654 Created TIMOB-25578 to actually remove it in 8.0.0.
  5. Hans Knöchel 2018-08-16

    Closing the old PR as we have a few other things to get straight before: - Remove generally deprecated Android geolocation API's (called "legacy mode") - Be clear about which API's should be deprecated, added or removed (as per Chris' comment [here](https://github.com/appcelerator/titanium_mobile/pull/9647#issuecomment-364253066))
  6. Christopher Williams 2018-12-17

    https://github.com/appcelerator/titanium_mobile/pull/10543
  7. Lokesh Choudhary 2018-12-19

    FR Passed. Waiting for conflicts to be resolved.
  8. Kota Iguchi 2018-12-20

    For Windows: https://github.com/appcelerator/titanium_mobile_windows/pull/1338
  9. Samir Mohammed 2019-01-02

    Conflicts still need to be resolved for https://github.com/appcelerator/titanium_mobile/pull/10543

JSON Source