[TIMOB-23704] Hyperloop: Improve error-message if Podfile has no Pods referenced
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2016-09-06T10:48:00.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 6.0.0, Hyperloop 2.0.0 |
Components | Hyperloop, iOS |
Labels | build, cocoapods, hyperloop, ios, qe-6.0.0 |
Reporter | Rodolfo Perottoni |
Assignee | Hans Knöchel |
Created | 2016-07-28T23:55:50.000+0000 |
Updated | 2016-09-29T18:45:40.000+0000 |
Description
Building a hyperloop enabled project with a Podfile that has no pods referenced (e.g. *compile 'Test'*) fails.
Steps to reproduce:
1. Create new project with HL enabled.
2. Create a Podfile and paste the following inside it:
platform :ios, '7.0'
target 'Hyperloop_Sample' do
end
3. Build the project. It fails at this part:
[INFO] [Hyperloop] CocoaPods dependencies found. This will take a few moments but will be cached for subsequent builds
[WARN] [Hyperloop] CocoaPods [!] Unable to load a specification for the plugin /Library/Ruby/Gems/2.0.0/gems/cocoapods-deintegrate-1.0.0
[INFO] [Hyperloop] Building CocoaPods dependencies
[WARN] [Hyperloop] CocoaPods xcodebuild: error: The project 'Pods.xcodeproj' contains no targets.
[ERROR] An error occurred during build after 9s 51ms
[ERROR] the xcodebuild failed running from /Users/rodolfo/Documents/Workspace/loopmodules-charts/Pods
I don't see the use-case for using a Podfile that does not hold any Pods. Since we are just delegating the call to the CocoaPods CLI. Let me know your thoughts about that.
I also think it doesn't make sense, but perhaps more people will face this in the future and won't find the cause of the problem quickly... so i would flag this as a "improvement" instead of bug.
PR: https://github.com/appcelerator/hyperloop.next/pull/67
Verified the improvement, If the podfile had no pod referenced it is now skipped: {noformat} [WARN] : [Hyperloop] Podfile found, but no pod's specified. Skipping ... {noformat} Tested On: {noformat} Mac OSX El Capitan 10.12 Ti SDK: 6.0.0.v20160929031439 Appc NPM: 4.2.8-7 App CLI: 6.0.0-54 Hyperloop: 2.0.0 Cocoapods:0.39.0 Xcode 8.0 Node v4.4.7 {noformat} *Closing ticket.*