Description
Currently, when using the
--wp-sdk option it will only allow a user to use 8.1 and 10.0 for possible values. When attempting to pass in an actual value for the SDK i.e. 10.0.10240.0, 10.0.10586.0 the CLI will not accept it as valid.
This option should be made to accept valid versions of the Windows SDK, similar to the
--ios-version option in ios-build
Steps to reproduce
Build a Windows project using appc run -p windows -T wp-device --wp-sdk 10.0.10586.0 --build-only
Actual result
The build will error with
Appcelerator Command-Line Interface, version 5.4.0-40
Copyright (c) 2014-2016, Appcelerator, Inc. All Rights Reserved.
Preproduction Environment Active
[ERROR] Invalid "--wp-sdk" value "10.0.10586.0"
Please select a valid wp-sdk value:
1) 8.1
2) 10.0
Select a value by number or name:
Expected result
The CLI should accept a valid version of the SDK for the --wp-sdk option
Sorry, I already worked on this. I'll push related PR soon.
https://github.com/appcelerator/titanium_mobile_windows/pull/818
[~gmathews] ok, sounds good (y)
https://github.com/appcelerator/titanium_mobile_windows/pull/818
Verified fixed, CLI now accepts and actual value of an SDK when using
--wp-sdk. When runningappc run -p windows -T wp-device --wp-sdk 10.0.10586.0 --build-onlyThe following appeared in the console.C:\Users\Tester\Desktop\Samir\testabc>appc run -p windows -T wp-device --wp-sdk 10.0.10586.0 --build-only Appcelerator Command-Line Interface, version 6.0.0 Copyright (c) 2014-2016, Appcelerator, Inc. All Rights Reserved. 12/1/2016, 3:38:19 PM Operating System Name = Microsoft Windows 10 Pro Version = 10.0.14393 Architecture = 64bit # CPUs = 4 Memory = 17034395648 Node.js Node.js Version = 4.4.4 npm Version = 2.11.3 Titanium CLI CLI Version = 5.0.10 Titanium SDK SDK Version = 6.1.0.v20161201064221 SDK Path = C:\ProgramData\Titanium\mobilesdk\win32\6.1.0.v20161201064221 Target Platform = windows Command C:\Program Files (x86)\nodejs\node.exe C:\Users\Tester\.appcelerator\install\6.0.0\package\node_modules\titanium\lib\titanium.js build run -p windows -T wp-device --wp-sdk 10.0.10586.0 --build-only --config-file C:\Users\Tester\AppData\Local\Temp\build-1480635487191.json --log-level info --no-banner --project-dir C:\Users\Tester\Desktop\Samir\testabc [INFO] Found Titanium module id=ti.cloud version=3.2.11 platform=commonjs deploy-type=test path=C:\ProgramData\Titanium\modules\commonjs\ti.cloud\3.2.11 [INFO] Found Titanium plugin id=com.soasta.touchtest.android version=latest [INFO] Found Titanium plugin id=hyperloop version=latest [INFO] Building for Windows Phone device [INFO] Performing build only [INFO] Deploy type: test [INFO] Debugging disabled [INFO] Profiler disabled [INFO] Forcing rebuild: target changed since last build [INFO] Was: wp-emulator [INFO] Now: wp-device [INFO] Using existing temporary pfx [INFO] JavaScript files need to be encrypted [INFO] Missing 7 app icons, generating missing icons [INFO] Square24x24Logo.png - Used for badge - size: 24x24 [INFO] Square44x44Logo.png - Used for logo - size: 44x44 [INFO] Square71x71Logo.png - Used for logo - size: 71x71 [INFO] Square150x150Logo.png - Used for logo - size: 150x150 [INFO] Logo.png - Used for logo - size: 150x150 [INFO] StoreLogo.png - Used for logo - size: 50x50 [INFO] SmallLogo.png - Used for logo - size: 30x30 [INFO] Processing JavaScript files [INFO] Encrypting JavaScript files: C:\ProgramData\Titanium\mobilesdk\win32\6.1.0.v20161201064221\windows\titanium_prep.win32.exe "com.appc.testabc" "C:\Users\Tester\.titanium\vsbuild\testabc\Assets" "app.js" "_app_props_.json" "_app_info_.json" [INFO] Generating i18n files [INFO] Writing appxmanifest C:\Users\Tester\.titanium\vsbuild\testabc\Package.store.appxmanifest.in [INFO] Writing appxmanifest C:\Users\Tester\.titanium\vsbuild\testabc\Package.phone.appxmanifest.in [INFO] Writing appxmanifest C:\Users\Tester\.titanium\vsbuild\testabc\Package.win10.appxmanifest.in [INFO] Generating Native Types [INFO] Setting up native modules for CMakeLists.txt... [INFO] Writing CMakeLists.txt: C:\Users\Tester\.titanium\vsbuild\testabc\CMakeLists.txt [INFO] Running cmake at C:\ProgramData\Titanium\mobilesdk\win32\6.1.0.v20161201064221\windows\cli\vendor\cmake\bin\cmake.exe in directory C:\Users\Tester\.titanium\vsbuild\testabc\win10.ARM [INFO] -- The C compiler identification is MSVC 19.0.24213.1 [INFO] -- The CXX compiler identification is MSVC 19.0.24213.1 [INFO] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_arm/cl.exe [INFO] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_arm/cl.exe -- works [INFO] -- Detecting C compiler ABI info [INFO] -- Detecting C compiler ABI info - done [INFO] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_arm/cl.exe [INFO] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_arm/cl.exe -- works [INFO] -- Detecting CXX compiler ABI info [INFO] -- Detecting CXX compiler ABI info - done [INFO] -- Detecting CXX compile features [INFO] -- Detecting CXX compile features - done [INFO] -- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY) [INFO] -- Found PythonInterp: C:/Python27/python.exe (found version "2.7.11") [INFO] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR [INFO] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed [INFO] -- Performing Test COMPILER_HAS_DEPRECATED [INFO] -- Performing Test COMPILER_HAS_DEPRECATED - Failed [INFO] -- Configuring done [INFO] -- Generating done [INFO] -- Build files have been written to: C:/Users/Tester/.titanium/vsbuild/testabc/win10.ARM [INFO] Targeting Windows SDK: 10.0.10586.0 [INFO] Running MSBuild on solution: C:\Users\Tester\.titanium\vsbuild\testabc\win10.ARM\Testabc.sln [INFO] Writing build manifest: C:\Users\Tester\.titanium\vsbuild\testabc\build-manifest.json [INFO] Copying results back to project build directory [INFO] Project built successfully in 31s 539ms