Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23829] Fails to detect Android NDK on Windows

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2016-08-26T18:56:16.000+0000
Affected Version/sRelease 5.4.0
Fix Version/sRelease 6.0.0
ComponentsTooling
Labelsregression
ReporterChris Barber
AssigneeChris Barber
Created2016-08-26T03:53:26.000+0000
Updated2016-10-27T14:16:04.000+0000

Description

A regression was introduced in Titanium SDK 5.4.0 with detecting the Android NDK on Windows. When Android NDK 11 came out, it no longer included RELEASE.txt which we relied on to determine if the folder contained a valid NDK. Thus Titanium could not find the NDK 11 install. TIMOB-20613 "improved" Android NDK detection by searching for specific files and directories within the NDK directory to validate it was indeed an NDK. However, there's a typo by which it searches for ndk-gdb.cmd instead of ndk-gdb-py.cmd on Windows.

Comments

  1. Chris Barber 2016-08-26

    Titanium Mobile master PR: https://github.com/appcelerator/titanium_mobile/pull/8270 Titanium Mobile 6_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/8271
  2. Chee Kiat Ng 2016-08-26

    Note. No need for back port to 5_X_X since ndk 11 is only required for 6_X_X and newer.
  3. Feon Sua Xin Miao 2016-08-26

    PR merged. *To Test* 1. Make sure Android NDK is installed 2. On osx and windows, run appc ti info -t android 3. Under Android NDK section of the output, you should see installed NDK info.
  4. Ewan Harris 2016-10-27

    Verified using: OS: Microsoft Windows 10 Pro 10.0.14393 Appc core: 6.0.0-67 Appc NPM: 4.2.8-9 Ti SDK: 6.0.0.v20161026195651 Android NDK r11: https://dl.google.com/android/repository/android-ndk-r11-windows-x86_64.zip Android NDK r11 is now detected on Windows. *Note* It seems that this was also 'fixed' in NDK r11b, see https://github.com/android-ndk/ndk/wiki/Changelog-r11#hotfix-r11b Closing ticket

JSON Source