[TIMOB-23847] VideoQuality - User is not able to set camera property to QUALITY_HIGH

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2016-09-01T07:48:38.000+0000
Affected Version/s	n/a
Fix Version/s	Release 6.0.0
Components	iOS
Labels	n/a
Reporter	Igor Stojanovic
Assignee	Hans Knöchel
Created	2016-08-31T12:39:10.000+0000
Updated	2016-09-22T17:53:22.000+0000

Description

1. property is set only if value is not equal to 0. file : MediaModule.m ... if (videoQuality != 0.0) { [picker setVideoQuality:videoQuality]; } 2. Default value is 1 (https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIImagePickerController_Class/#//apple_ref/c/tdef/UIImagePickerControllerQualityType) 3. So user is never able to set value to 0 and reach out the HIGH quality. Please take a look on attached image.

Attachments

File	Date	Size
bug_MediaModule.png	2016-08-31T12:31:02.000+0000	91231

Comments

Hans Knöchel 2016-08-31

Gooooood catch! Will move to TIMOB and schedule it.

Hans Knöchel 2016-08-31

Ok, I fixed it and also added the missing quality-constants. PR: https://github.com/appcelerator/titanium_mobile/pull/8293 Demo:

   var win = Ti.UI.createWindow({
       backgroundColor: "#fff"
   });
   var btn = Ti.UI.createButton({
       title: "Take video with high quality"
   });
    
   btn.addEventListener("click", function() {
       Ti.Media.showCamera({
           mediaTypes: [Ti.Media.MEDIA_TYPE_VIDEO],
           videoQuality: Ti.Media.QUALITY_HIGH
       });
   });
    
   win.add(btn);
   win.open();

Chee Kiat Ng 2016-09-01

CR and FT passed. Please do a back port for 6.0.0 and change the apidocs min version to 6.
Eric Wieber 2016-09-22

Verified fixed, using: MacOS 10.12 (16A323) Studio 4.7.1.201609100950 Ti SDK 6.0.0.v20160921004951 Appc NPM 4.2.7 Appc CLI 6.0.0-7 Alloy 1.9.1 Xcode 8.0 (8A218a) Video quality can be correctly set to high, without issue. Tested by using the provided test code as well as changing it to record at medium quality then comparing video size/quality in the container.

JSON Source