Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23860] Android: Update Google Play services used by cloudpush module

GitHub Issuen/a
TypeImprovement
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2016-10-05T03:27:59.000+0000
Affected Version/sn/a
Fix Version/sRelease 6.0.0
ComponentsAndroid
Labelscloudpush
ReporterGary Mathews
AssigneeGary Mathews
Created2016-09-03T12:06:43.000+0000
Updated2016-11-08T17:38:10.000+0000

Description

The current google-play-services-base.jar used by [cloudpush](https://github.com/appcelerator-modules/cloudpush/tree/master/android/lib) is outdated and causes apps to be rejected when submitted to the play store.

Attachments

FileDateSize
ti.cloudpush-android-3.4.2.zip2016-09-04T04:14:25.000+0000878552
ti.cloudpush-android-4.0.1.zip2016-09-03T14:42:23.000+0000864520

Comments

  1. Gary Mathews 2016-09-03

    master: https://github.com/appcelerator-modules/cloudpush/pull/29 ti.cloudpush-4.0.1: https://github.com/appcelerator-modules/cloudpush/releases/tag/android-4.0.1 NOTE: ti.cloudpush 4.0.0+ is only compatible with Titanium SDK 6.0.0+
  2. Motiur Rahman 2016-09-03

    [~nibbleabit] Now which module version needs to use for avoiding the rejection? Since Ti SDK 6 not release yet. Or any workaround? Thanks.
  3. Gary Mathews 2016-09-04

  4. Gary Mathews 2016-09-30

    1. ti.map: https://github.com/appcelerator-modules/ti.map/pull/183 ti.admob: https://github.com/appcelerator-modules/ti.admob/pull/63 2. Waiting for review of PRs 3. Module ti.cloudpush-3.4.2 was made for a customer since they are on <6.0.0
  5. Chee Kiat Ng 2016-10-04

    [~gmathews] I think the PRs are fine. Just curious why travis is failing, hopefully Chris or you have some insight to fix that before i merge the PRs. And I think you can go ahead to prepare the TiSDK PRs for master and 6_0_X that includes both the cloud push and the map.
  6. Gary Mathews 2016-10-04

    I have updated the the current PRs and created a new one for cloudpush to update Google Play Services to 9.6.1. I managed to fix module compilation for ti.admob and ti.map too. ti.admob: https://github.com/appcelerator-modules/ti.admob/pull/63 ti.map: https://github.com/appcelerator-modules/ti.map/pull/183 cloudpush: https://github.com/appcelerator-modules/cloudpush/pull/30 ti.admob: https://github.com/appcelerator-modules/ti.admob/releases/tag/android-3.0.1 ti.map: https://github.com/appcelerator-modules/ti.map/releases/tag/android-3.0.1 cloudpush: https://github.com/appcelerator-modules/cloudpush/releases/tag/android-4.0.2 titanium_mobile: https://github.com/appcelerator/titanium_mobile/pull/8404 6_0_X: https://github.com/appcelerator/titanium_mobile/pull/8405
  7. Chee Kiat Ng 2016-10-05

    PRs merged.
  8. Lokesh Choudhary 2016-11-08

  9. Lokesh Choudhary 2016-11-08

    Verified the fix. Closing. Appc Studio : 4.8.0.201611020954 SDK Version : 6.0.0.v20161107075927 Mac OS Version : 10.11.6 Xcode Version : Xcode 8.1 Build version 8B62 Appc CLI AND Appc NPM : {"NPM":"4.2.8-9","CLI":"6.0.0-69"} Ti CLI : 5.0.10 Alloy : 1.9.4 Node : v4.6.0

JSON Source