Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23897] iOS: Support Ti.Facebook 5.2.5 on Titanium SDK < 5.5.0

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2016-09-13T19:54:45.000+0000
Affected Version/sn/a
Fix Version/sRelease 5.5.0
ComponentsiOS
Labelsfacebook, ios
ReporterHans Knöchel
AssigneeHans Knöchel
Created2016-09-13T08:10:06.000+0000
Updated2016-09-16T18:01:42.000+0000

Description

Because of the changes in TIMOB-23890, we made major core-changes that required the module to run on Titanium SDK 5.5.0 or later. I can think of a fix to support it on Titanium SDK < 5.5.0 (down to 5.0.0) as well. That fix should be applied.

Comments

  1. Hans Knöchel 2016-09-13

    PR: https://github.com/appcelerator-modules/ti.facebook/pull/66

    Steps to test (from TIMOB-23890)

    Scenario A: Use the case above. It will fail to log in without crashing. Scenario B: Using the same case, follow these instructions to include a appname.entitlements in platform/ios: {quote} *Using Facebook module with iOS 10 and Xcode 8* To log in using facebook, we now have to include an entitlements file that enables Keychain Sharing Capabilities. To do so, create a /platform/ios/<appname>.entitlements file with this content {quote} 
       <?xml version="1.0" encoding="UTF-8"?>
   <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
   <plist version="1.0">
   <dict>
       <key>keychain-access-groups</key>
       <array>
           <!-- APP_ID same as the id value in the tiapp.xml file -->
           <string>$(AppIdentifierPrefix)APP_ID</string>
       </array>
   </dict>
   </plist>
  2. Chee Kiat Ng 2016-09-13

    5_5_X PR: https://github.com/appcelerator/titanium_mobile/pull/8372 6_0_X PR:https://github.com/appcelerator/titanium_mobile/pull/8373 master PR: https://github.com/appcelerator/titanium_mobile/pull/8374 facebook PR: https://github.com/appcelerator-modules/ti.facebook/pull/66 APPROVED.
  3. Eric Merriman 2016-09-14

    Verified fixed with: NPM Version: 2.15.1 Node Version: 4.4.3 Mac OS: 10.11.2 Appc CLI: 5.5.0 Appc CLI NPM: 4.2.7 Titanium SDK version: 5.5.0.GA Appcelerator Studio, build: 4.7.1.201609100950 Xcode 8.0 GM Using multiple samples, was able to log in and post with Facebook 5.2.5 module.
  4. Brian Freid 2016-09-16

    Issue still exists, please reopen this issue.

JSON Source