Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23948] Hyperloop - CLI: Replace deprecated wrench with fs-extra

GitHub Issuen/a
TypeBug
PriorityLow
StatusClosed
ResolutionFixed
Resolution Date2017-03-24T11:15:22.000+0000
Affected Version/sn/a
Fix Version/sHyperloop 2.2.0
ComponentsHyperloop, Tooling
Labelsn/a
ReporterHans Knöchel
AssigneeHans Knöchel
Created2016-09-24T17:17:47.000+0000
Updated2017-09-29T18:38:52.000+0000

Description

The node-library wrench has been deprecated for a while now and the vendor recommends to use fs-extra instead. As we already use fs, we could replace that one and use the common methods to replace the wrench-calls, which basically only are rmdirSyncRecursive and mkdirSyncRecursive that could be replaced with removeSync and mkdirsSync that take the same arguments.

Comments

  1. Chris Barber 2016-09-26

    I wouldn't call this a high or a medium priority. It's not like wrench.js doesn't currently work.
  2. Hans Knöchel 2016-09-26

    Yeah, fine with that. Just to not forget it. Thanks!
  3. Hans Knöchel 2017-02-03

    PR: https://github.com/appcelerator/hyperloop.next/pull/120
  4. Lokesh Choudhary 2017-09-29

    Verified by looking at the changes wrench was replaced by extra-fs, rmdirSyncRecursive replaced by removeSync & mkdirSyncRecursive by mkdirsSync. Closing. Studio Ver: 4.10.0.201709271713 SDK Ver: 6.2.2.GA OS Ver: 10.12.3 Xcode Ver: Xcode 8.3.3 Appc NPM: 4.2.9 Appc CLI: 6.2.4 Ti CLI Ver: 5.0.14 Alloy Ver: 1.9.14 Node Ver: 7.10.1 Java Ver: 1.8.0_101 Devices: ⇨ google Pixel --- Android 7.1.1 Hyperloop: 2.2.0RC2

JSON Source